[linux-yocto] [PATCH 1/2] [KERNEL] meta: Add new pci iov feature.

[Bruce Ashfield]

On 12-08-14 02:11 PM, Bodke, Kishore K wrote:
>
>
>> -----Original Message-----
>> From: Bruce Ashfield [mailto:bruce.ashfield at windriver.com]
>> Sent: Tuesday, August 14, 2012 8:40 AM
>> To: Bodke, Kishore K
>> Cc: linux-yocto at yoctoproject.org; dvhart at linux.intel.com
>> Subject: Re: [PATCH 1/2] [KERNEL] meta: Add new pci iov feature.
>>
>> On 12-08-13 07:07 PM, kishore.k.bodke at intel.com wrote:
>>> From: Kishore Bodke<kishore.k.bodke at intel.com>
>>>
>>> Add Single Root PCI I/O Virtualization feature to meta.
>>>
>>> Signed-off-by: Kishore Bodke<kishore.k.bodke at intel.com>
>>> ---
>>>    meta/cfg/kernel-cache/features/pci-iov/pci-iov.cfg |    1 +
>>>    meta/cfg/kernel-cache/features/pci-iov/pci-iov.scc |    1 +
>>>    2 files changed, 2 insertions(+)
>>>    create mode 100644 meta/cfg/kernel-cache/features/pci-iov/pci-iov.cfg
>>>    create mode 100644 meta/cfg/kernel-cache/features/pci-iov/pci-iov.scc
>>>
>>> diff --git a/meta/cfg/kernel-cache/features/pci-iov/pci-iov.cfg
>> b/meta/cfg/kernel-cache/features/pci-iov/pci-iov.cfg
>>> new file mode 100644
>>> index 0000000..c52af46
>>> --- /dev/null
>>> +++ b/meta/cfg/kernel-cache/features/pci-iov/pci-iov.cfg
>>> @@ -0,0 +1 @@
>>> +CONFIG_PCI_IOV=y
>>> diff --git a/meta/cfg/kernel-cache/features/pci-iov/pci-iov.scc
>> b/meta/cfg/kernel-cache/features/pci-iov/pci-iov.scc
>>> new file mode 100644
>>> index 0000000..d699309
>>> --- /dev/null
>>> +++ b/meta/cfg/kernel-cache/features/pci-iov/pci-iov.scc
>>> @@ -0,0 +1 @@
>>
>> What about a short KFEATURE_DESCRIPTION and KFEATURE_COMPATIBILITY
>> ?
>>
>> There are some tools that can scan these, and present them as options
>> to someone creating a BSP, so having a description and compatibility
>> would definitely help.
>>
>> Here's the one from the xhci fragment:
>>
>> define KFEATURE_DESCRIPTION "Enable options for xhci (USB 3.0)"
>> define KFEATURE_COMPATIBILITY board
>>
>
> Could you please point me where these definitions are ?
> I will try with these options and submit a new patch.

Many of the .scc files in your meta branch have examples:

http://git.yoctoproject.org/cgit/cgit.cgi/yocto-kernel-cache/tree/features/cgroups/cgroups.scc

There aren't any strict rules:

   - make the description summarize what someone including the featuer
     will get

   - if there is board compatbility, indicate that. i.e. it needs something
     from a particular machine (driver, etc), if it doesn't need anything
     or is a generic feature "all" is the compatibility. In your case,
     'board' would be appropriate.

Cheers,

Bruce

>
> Thanks
> Kishore.
>
>>
>> Bruce
>>
>>> +kconf hardware pci-iov.cfg
>