[linux-yocto] [PATCH v2 12/17] media-platform: A feature for platform media devices

[Hart, Darren]

On Mon, 2013-12-09 at 17:00 +0000, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: Hart, Darren
> > Sent: Monday, December 09, 2013 8:32 AM
> > To: Kamble, Nitin A
> > Cc: bruce.ashfield at windriver.com; linux-yocto at yoctoproject.org
> > Subject: Re: [PATCH v2 12/17] media-platform: A feature for platform media
> > devices
> > 
> > On Fri, 2013-12-06 at 21:51 -0800, nitin.a.kamble at intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > >
> > > Create a feature fragment for enabling platform media devices.
> > 
> > This one seems like it might be incomplete. The first option enables a block of
> > other options, but only DEINTERLACE was enabled of the entire block. This
> > isn't Nitin's doing, it's just what was in the media.cfg blob I tossed over the
> > over the wall to him.
> > 
> > Hrm. I don't see any dependencies on DEINTERLACE from other drivers...
> > but it is a generic deinterlacing driver for V4L... which seems to me to be
> > something we would want in general... while the others, not so much.
> > So... OK, I guess it's the right way to go... despite looking a bit odd.
> > 
> 
> 
> I had similar feeling while creating this fragment. I also tried to
> avoid creating this.
> Putting it in the media.cfg was not working well, because it was
> enabling some of the unwanted media drivers without asking.

Thanks Nitin, I think it is reasonable as it stands today. As these
fragments get used, a more optimal division might manifest, but for now,
I think this is correct.

--
Darren

> 
> Thanks,
> Nitin
> 
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > 
> > Reviewed-by: Darren Hart <dvhart at linux.intel.com>
> > 
> > > ---
> > >  meta/cfg/kernel-cache/features/media/media-platform.cfg | 5 +++++
> > > meta/cfg/kernel-cache/features/media/media-platform.scc | 6 ++++++
> > >  2 files changed, 11 insertions(+)
> > >  create mode 100644
> > > meta/cfg/kernel-cache/features/media/media-platform.cfg
> > >  create mode 100644
> > > meta/cfg/kernel-cache/features/media/media-platform.scc
> > >
> > > diff --git a/meta/cfg/kernel-cache/features/media/media-platform.cfg
> > > b/meta/cfg/kernel-cache/features/media/media-platform.cfg
> > > new file mode 100644
> > > index 0000000..31b53bd
> > > --- /dev/null
> > > +++ b/meta/cfg/kernel-cache/features/media/media-platform.cfg
> > > @@ -0,0 +1,5 @@
> > > +#
> > > +# Media Platform Configuration
> > > +#
> > > +CONFIG_V4L_MEM2MEM_DRIVERS=y
> > > +CONFIG_VIDEO_MEM2MEM_DEINTERLACE=m
> > > diff --git a/meta/cfg/kernel-cache/features/media/media-platform.scc
> > > b/meta/cfg/kernel-cache/features/media/media-platform.scc
> > > new file mode 100644
> > > index 0000000..474406c
> > > --- /dev/null
> > > +++ b/meta/cfg/kernel-cache/features/media/media-platform.scc
> > > @@ -0,0 +1,6 @@
> > > +define KFEATURE_DESCRIPTION "Enable Configuration For Platform
> > Media devices"
> > > +define KFEATURE_COMPATIBILITY all
> > > +
> > > +include media.scc
> > > +
> > > +kconf hardware media-platform.cfg
> > 
> > --
> > Darren Hart
> > Intel Open Source Technology Center
> > Yocto Project - Linux Kernel
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel