[linux-yocto] [PATCH 4/6] v4l2: config fragment for enabling v4l2 interface to camera devices

[Kamble, Nitin A]

> -----Original Message-----
> From: linux-yocto-bounces at yoctoproject.org [mailto:linux-yocto-
> bounces at yoctoproject.org] On Behalf Of Bruce Ashfield
> Sent: Wednesday, July 03, 2013 8:42 PM
> To: Development list for the linux-yocto*.git Linux kernel repositories
> Subject: Re: [linux-yocto] [PATCH 4/6] v4l2: config fragment for enabling v4l2
> interface to camera devices
> 
> On Tue, Jul 2, 2013 at 4:05 PM,  <nitin.a.kamble at intel.com> wrote:
> > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> >
> > This config fragment enables the v4l2 kernel interface to camera
> > devices. With it standard v4l2 user level utilities can connect with
> > the camera.
> >
> > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > ---
> >  meta/cfg/kernel-cache/features/media/v4l2.cfg | 21
> > +++++++++++++++++++++  meta/cfg/kernel-
> cache/features/media/v4l2.scc |
> > 6 ++++++
> >  2 files changed, 27 insertions(+)
> >  create mode 100644 meta/cfg/kernel-cache/features/media/v4l2.cfg
> >  create mode 100644 meta/cfg/kernel-cache/features/media/v4l2.scc
> >
> > diff --git a/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > b/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > new file mode 100644
> > index 0000000..614886c
> > --- /dev/null
> > +++ b/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > @@ -0,0 +1,21 @@
> > +# Enable the V4L2 core and API
> > +CONFIG_VIDEO_DEV=m
> > +CONFIG_VIDEO_V4L2=m
> > +VIDEO_V4L2_SUBDEV_API=y
> > +
> > +# Used by drivers that need v4l2-mem2mem.ko
> V4L2_MEM2MEM_DEV=m
> > +
> > +# Used by drivers that need Videobuf modules VIDEOBUF_GEN=m
> > +VIDEOBUF_DMA_SG=m VIDEOBUF_VMALLOC=m
> VIDEOBUF_DMA_CONTIG=m
> > +VIDEOBUF_DVB=m
> > +
> > +# Used by drivers that need Videobuf2 modules
> CONFIG_VIDEOBUF2_CORE=m
> > +CONFIG_VIDEOBUF2_MEMOPS=m CONFIG_VIDEOBUF2_VMALLOC=m
> > +VIDEOBUF2_DMA_CONTIG=m VIDEOBUF2_DMA_SG=m
> > diff --git a/meta/cfg/kernel-cache/features/media/v4l2.scc
> > b/meta/cfg/kernel-cache/features/media/v4l2.scc
> > new file mode 100644
> > index 0000000..09ab7d6
> > --- /dev/null
> > +++ b/meta/cfg/kernel-cache/features/media/v4l2.scc
> > @@ -0,0 +1,6 @@
> > +define KFEATURE_DESCRIPTION "Enable Video for Linux 2 as a module"
> > +define KFEATURE_COMPATIBILITY all
> > +
> > +include media-camera.scc
> 
> This makes me wonder. Do you always want the media-camera modules
> when you want the video4linux parts ? I know in your case you do, but I'm
> asking for the general case. If so, would it be better to just have your BSP
> include the two separate fragments and keep them apart ?
> 
> Bruce
> 


In this case, the media_camera configs are needed to enable the v4l2 config options.
Media_camera configs do not enable any camera, but it enables the underneath camera
media kernel interfaces used by camera drivers and v4l2 kind of drivers.
   Hence there is no need to re-organize this commit.

Thanks,
Nitin


> > +
> > +kconf non-hardware v4l2.cfg
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > linux-yocto mailing list
> > linux-yocto at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/linux-yocto
> 
> 
> 
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
> _______________________________________________
> linux-yocto mailing list
> linux-yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/linux-yocto