[linux-yocto] [PATCH 7/8] pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32
Darren Hart
dvhart at linux.intel.com
Wed Oct 16 12:43:27 PDT 2013
Avoid using magic numbers when we have perfectly good defines just lying
around.
Signed-off-by: Darren Hart <dvhart at linux.intel.com>
Cc: "David S. Miller" <davem at davemloft.net>
Cc: "H. Peter Anvin" <hpa at zytor.com>
Cc: Peter Waskiewicz <peter.p.waskiewicz.jr at intel.com>
Cc: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Cc: netdev at vger.kernel.org
---
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 7e3410e..988fd81 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -682,7 +682,7 @@ static int pch_gbe_init_phy(struct pch_gbe_adapter *adapter)
}
adapter->hw.phy.addr = adapter->mii.phy_id;
netdev_dbg(netdev, "phy_addr = %d\n", adapter->mii.phy_id);
- if (addr == 32)
+ if (addr == PCH_GBE_PHY_REGS_LEN)
return -EAGAIN;
/* Selected the phy and isolate the rest */
for (addr = 0; addr < PCH_GBE_PHY_REGS_LEN; addr++) {
--
1.7.9.5
More information about the linux-yocto
mailing list