[linux-yocto] [PATCH 8/8] meta/common-pc-64: Add USB 3.0 support

[Paul Gortmaker]

[[linux-yocto] [PATCH 8/8] meta/common-pc-64: Add USB 3.0 support] On 06/09/2013 (Fri 15:44) Darren Hart wrote:

> Add missing xhci-hcd to common-pc-64.scc.

At the risk of being a nag, the commit log just repeats what is obvious
from patch inspection.  I try and encourage people to list three things
in commit logs: (1) user visible symptoms, (2) underlying reason for it,
and (3) how to fix it, if it isn't obvious.

It seems we are missing #1 (and perhaps #2) here.  Perhaps we can add:

  The 64 bit common-pc BSP will not by default enable USB 3.0 devices
  because <insert reason here>.  This happens because the xhci feature
  contains <blah blah blah> but yet it isn't added/included by default.
  We can add <blah blah xhci> because it will do sensible probing and
  not change behaviour on older platforms where the underlying hardware
  can't support <blah blah blah>.

Note that the above has three sentences that directly map onto the same
three commit log "suggestion" topic points.

Thanks,
Paul.
--

> 
> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> ---
>  .../kernel-cache/bsp/common-pc-64/common-pc-64.scc |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> index 29c47dd..7ab6449 100644
> --- a/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> +++ b/meta/cfg/kernel-cache/bsp/common-pc-64/common-pc-64.scc
> @@ -8,6 +8,7 @@ include cfg/x86_64.scc
>  include features/usb/ehci-hcd.scc
>  include features/usb/uhci-hcd.scc
>  include features/usb/ohci-hcd.scc
> +include features/usb/xhci-hcd.scc
>  include features/usb/touchscreen-composite.scc
>  include features/intel-e1xxxx/intel-e100.scc
>  include features/intel-e1xxxx/intel-e1xxxx.scc
> -- 
> 1.7.9.5
> 
> _______________________________________________
> linux-yocto mailing list
> linux-yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/linux-yocto