[linux-yocto] [PATCH 8/8] meta/common-pc-64: Add USB 3.0 support

[Paul Gortmaker]

[Re: [linux-yocto] [PATCH 8/8] meta/common-pc-64: Add USB 3.0 support] On 07/09/2013 (Sat 01:11) Darren Hart wrote:

> On Fri, 2013-09-06 at 18:56 -0400, Paul Gortmaker wrote:
> > [[linux-yocto] [PATCH 8/8] meta/common-pc-64: Add USB 3.0 support] On 06/09/2013 (Fri 15:44) Darren Hart wrote:
> > 
> > > Add missing xhci-hcd to common-pc-64.scc.
> > 
> > At the risk of being a nag, the commit log just repeats what is obvious
> > from patch inspection.  I try and encourage people to list three things
> > in commit logs: (1) user visible symptoms, (2) underlying reason for it,
> > and (3) how to fix it, if it isn't obvious.
> > 
> > It seems we are missing #1 (and perhaps #2) here.  Perhaps we can add:
> > 
> >   The 64 bit common-pc BSP will not by default enable USB 3.0 devices
> >   because <insert reason here>.  This happens because the xhci feature
> >   contains <blah blah blah> but yet it isn't added/included by default.
> >   We can add <blah blah xhci> because it will do sensible probing and
> >   not change behaviour on older platforms where the underlying hardware
> >   can't support <blah blah blah>.
> > 
> > Note that the above has three sentences that directly map onto the same
> > three commit log "suggestion" topic points.
> > 
> 
> Arg... wtf is wrong with this list? it eats Cc's...

One of the other yocto lists was doing the same, and I nagged enough
that someone finally fixed it.  Alas I guess the broken behaviour seems
to be the default however.

> 
> Heh. Nice. I'm usually the one giving that speech. I think it's rather
> overkill for this particular one, but sure. I've updated the commit
> branch with:
> 
> The 64 bit common-pc BSP will not by default enable USB 3.0 devices
> because it was missing the xhci fragment with the CONFIG_USB_XHCI_HCD
> option. This is generally safe for a generic BSP as the driver is
> properly probed and detected.

Looks good, thanks.

P.
--

> 
> Thanks for the vigilance. :-)
> 
> -- 
> Darren Hart
> Intel Open Source Technology Center
> Yocto Project - Linux Kernel
> 
>