[linux-yocto] [PATCH 5/6] x32: Drop x32 config

[Bruce Ashfield]

On 14-04-02 11:11 AM, Stanacar, StefanX wrote:
>
>
>
> On Wed, 2014-04-02 at 00:19 -0700, Darren Hart wrote:
>> CONFIG_X86_32 is a non-selectable configuration item, automatically set
>> by ARCH and !CONFIG_64BIT. There are no users of the .cfg nor the .scc.
>> Delete them.
>>
>> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
>> ---
>>   meta/cfg/kernel-cache/cfg/x32.cfg |    1 -
>>   meta/cfg/kernel-cache/cfg/x32.scc |    4 ----
>>   2 files changed, 5 deletions(-)
>>   delete mode 100644 meta/cfg/kernel-cache/cfg/x32.cfg
>>   delete mode 100644 meta/cfg/kernel-cache/cfg/x32.scc
>>
>
> Does this mean oe-core will need an update on linux-yocto*.bb which has:
>
> KERNEL_FEATURES_append = " ${@bb.utils.contains("TUNE_FEATURES", "mx32",
> " cfg/x32.scc", "" ,d)}"

Yes it does. I even grepped/checked for this explicitly and missed it.
To top it off, I pushed the change by mistake (long story) this morning.

So if we update SRCREVs, this breaks the build for 3.14 based kernels.

We could keep an empty .scc file around to keep the interface consistent
(and comment in the .scc file why it is empty), or do the updates.

preferences ?

Bruce

>
> ?
>
> Cheers,
> Stefan
>
>
>> diff --git a/meta/cfg/kernel-cache/cfg/x32.cfg b/meta/cfg/kernel-cache/cfg/x32.cfg
>> deleted file mode 100644
>> index 725e05f..0000000
>> --- a/meta/cfg/kernel-cache/cfg/x32.cfg
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -CONFIG_X86_X32=y
>> diff --git a/meta/cfg/kernel-cache/cfg/x32.scc b/meta/cfg/kernel-cache/cfg/x32.scc
>> deleted file mode 100644
>> index e4b954a..0000000
>> --- a/meta/cfg/kernel-cache/cfg/x32.scc
>> +++ /dev/null
>> @@ -1,4 +0,0 @@
>> -define KFEATURE_DESCRIPTION "x86 x32 support"
>> -define KFEATURE_COMPATIBILITY arch
>> -
>> -kconf non-hardware x32.cfg
>> --
>> 1.7.9.5
>>
>