[linux-yocto] [PATCH 07/10] stmicro: Add support for the STMMAC Ethernet controller family

[Darren Hart]

On 7/1/15 9:57 AM, Saul Wold wrote:
> This is needed for the x1000 SOC platform

This is on the SoC itself? Not an additional chip on the board?

> Signed-off-by: Saul Wold <sgw at linux.intel.com>
> ---
>  meta/cfg/kernel-cache/features/stmicro/stmmac.cfg | 6 ++++++
>  meta/cfg/kernel-cache/features/stmicro/stmmac.scc | 2 ++
>  2 files changed, 8 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/features/stmicro/stmmac.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/stmicro/stmmac.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/stmicro/stmmac.cfg b/meta/cfg/kernel-cache/features/stmicro/stmmac.cfg
> new file mode 100644
> index 0000000..63e06d61
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/stmicro/stmmac.cfg
> @@ -0,0 +1,6 @@
> +CONFIG_NET_CORE=y
> +CONFIG_ETHERNET=y
> +CONFIG_NET_VENDOR_STMICRO=y
> +CONFIG_STMMAC_ETH=y
> +CONFIG_STMMAC_PLATFORM=y
> +CONFIG_STMMAC_PCI=y
> diff --git a/meta/cfg/kernel-cache/features/stmicro/stmmac.scc b/meta/cfg/kernel-cache/features/stmicro/stmmac.scc
> new file mode 100644
> index 0000000..7951713b
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/stmicro/stmmac.scc
> @@ -0,0 +1,2 @@
> +
> +kconf hardware stmmac.cfg


Taking a closer look at the current set of features, they are mostly
topical, rather than vendor. I'm surprised to find we don't have a "net"
in there yet. We do have "net" in cfg (rather than features), but that's
more about protocols than drivers (inexplicably so).

In my opinion, this would be better organized as:

features/
  net/
    net.scc
    net.cfg
    net-all.scc
    stmicro/
      stmmac.scc (includes net.cfg)
      stmmac.cfg

Similar to the features/media setup.

Bruce, any preference? I think we need a couple of READMEs in the
kernel-cache hierarchy (cfg, features, ktype, etc. to help guide folks
creating fragments). I would suggest following the Kconfig hierarchy as
much as possible to avoid confusion.

-- 
Darren Hart
Intel Open Source Technology Center