[linux-yocto] [PATCH] uvesafb: print error message when task timeout occurs

[Jianxun Zhang]

On 04/20/2016 05:48 AM, Saul Wold wrote:
> On Tue, 2016-04-19 at 13:46 -0400, Bruce Ashfield wrote:
>> On 2016-04-14 6:26 PM, Jianxun Zhang wrote:
>>>
>>> The driver waits for response from user space for a pending
>>> task until a timeout (UVESAFB_TIMEOUT) occurs. But the
>>> existing error message in later steps is a little obscure.
>> Sorry for the slow reply, my filters managed to hide this from
>> me.
>>
>> This looks fine to me, but what kernel versions did you test it ?
>> 4.4 ? 4.1 ?
>>
> This would be for 4.4 and 4.1. Initial testing was done with 4.1
> kernel.
>
> Sau!

Bruce & Saul,
The patch was tested on qemu which is using uvesafb. This work is based 
on linux-yocto 4.4.3.

>
>> Bruce
>>
>>>
>>>
>>> This patch throws out an error message when timeout happens.
>>>
>>> Signed-off-by: Jianxun Zhang <jianxun.zhang at linux.intel.com>
>>> ---
>>>    drivers/video/fbdev/uvesafb.c | 6 +++++-
>>>    1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/fbdev/uvesafb.c
>>> b/drivers/video/fbdev/uvesafb.c
>>> index 178ae93..13bbb61 100644
>>> --- a/drivers/video/fbdev/uvesafb.c
>>> +++ b/drivers/video/fbdev/uvesafb.c
>>> @@ -211,9 +211,13 @@ static int uvesafb_exec(struct uvesafb_ktask
>>> *task)
>>>    	} else if (err == -ENOBUFS)
>>>    		err = 0;
>>>
>>> -	if (!err && !(task->t.flags & TF_EXIT))
>>> +	if (!err && !(task->t.flags & TF_EXIT)) {
>>>    		err = !wait_for_completion_timeout(task->done,
>>>    				msecs_to_jiffies(UVESAFB_TIMEOUT)
>>> );
>>> +		if (err)
>>> +			printk_ratelimited(KERN_ERR "uvesafb: %u
>>> ms task timeout error\n",
>>> +					UVESAFB_TIMEOUT);
>>> +	}
>>>
>>>    	mutex_lock(&uvfb_lock);
>>>    	uvfb_tasks[seq] = NULL;
>>>