[linux-yocto] [PATCH] features/powertop: To provide wakeup/seconds events

[Bacchewar, Nilesh]

Thanks Saul for your comment. We will check if this can help us & revisit the requirement if  needs.

Regards,
Nilesh

-----Original Message-----
From: Saul Wold [mailto:sgw at linux.intel.com] 
Sent: Thursday, July 21, 2016 12:27 AM
To: Bacchewar, Nilesh <nilesh.bacchewar at intel.com>; linux-yocto at yoctoproject.org
Subject: Re: [linux-yocto] [PATCH] features/powertop: To provide wakeup/seconds events

On Wed, 2016-07-20 at 16:20 -0700, Nilesh Bacchewar wrote:
> 
> for powertop to provide wakeup/seconds events
> 
> Signed-off-by: Nilesh Bacchewar <nilesh.bacchewar at intel.com>
> ---
>  features/powertop/powertop.cfg   | 5 +++++
>  features/soc/broxton/broxton.scc | 2 ++
>  2 files changed, 7 insertions(+)
>  create mode 100644 features/powertop/powertop.cfg
> 
> diff --git a/features/powertop/powertop.cfg 
> b/features/powertop/powertop.cfg new file mode 100644 index 
> 0000000..922a731
> --- /dev/null
> +++ b/features/powertop/powertop.cfg
> @@ -0,0 +1,5 @@
> +# make debugging options available
> +CONFIG_DEBUG_KERNEL=y
> +
I thought that the Ostro team did not want DEBUG_KERNEL enabled, I realize that it might be required for TIMER_STATS, but I think you would want to enable this via the developer kernel, rather than the -standard kernel, this is why there is a split.

TIMER_STATS is already part of the -developer kernel via the profiling.scc

I think I would rather see the -developer kernel be used for validation, if that's what your trying to do, instead of polluting the -standard kernel with DEBUG items.

Sau!

> 
> +# Collect kernel timers statistics
> +CONFIG_TIMER_STATS=y
> diff --git a/features/soc/broxton/broxton.scc
> b/features/soc/broxton/broxton.scc
> index 8e268e5..aea7bbd 100644
> --- a/features/soc/broxton/broxton.scc
> +++ b/features/soc/broxton/broxton.scc
> @@ -14,4 +14,6 @@ include features/usb/designware-usb3.scc
>  include features/intel-pinctrl/intel-pinctrl.scc
>  include features/usb/usb-typec.scc
>  
> +include features/powertop/powertop.scc
> +
>  kconf hardware broxton.cfg
> --
> 1.9.1
>