[linux-yocto] [PATCH] gpio-pca953x: add PCAL9535 interrupt support

Bruce Ashfield bruce.ashfield at windriver.com
Wed Mar 30 09:38:14 PDT 2016


On 16-03-30 07:34 AM, Puustinen, Ismo wrote:
> Hi!
>
> On Wed, 2016-03-30 at 16:37 +0800, Yong Li wrote:
>> Galileo gen 2 board uses the PCAL9535 as the GPIO expansion,
>> it is different from PCA9535 and includes interrupt mask/status
>> registers,
>> The current driver does not support the interrupt registers
>> configuration,
>> it causes some gpio pins cannot trigger interrupt events,
>> this patch fix this issue. The original patch was submitted by
>> Josef Ahmad <josef.ahmad at linux.intel.com>
>> http://git.yoctoproject.org/cgit/cgit.cgi/meta-intel-quark/tree/recip
>> es-kernel/linux/files/0015-Quark-GPIO-1-2-quark.patch
>>
>> Upstream-Status: submission pending
>>
>> Signed-off-by: Yong Li <sdliyong at gmail.com>
>>
>
> I tried out this patch briefly and it appears to work. At least I could
> get proper interrupt events on ADC pins on Galileo 2.
>
> However, we should IMHO move this patch below the custom "drive"
> property patch in the kernel git tree (and modify the drive property
> patch accordingly). This patch could then be submitted to real kernel
> upstream because it wouldn't depend on patches that can't upstreamed.

We could do this, but we need a revert, this patch fixed up, and then
the modified custom driver property patch. Since the tree is fast
forward, and I only rebase when jumping kernel versions.

If someone want to do that, I'll take the patches, since something
upstream ready is preferable.

I'll hold off merging this until I hear one way or the other.

Bruce

>
> Ismo
>



More information about the linux-yocto mailing list