[linux-yocto] [yocto-2.2.1][PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"

[Bruce Ashfield]

On Mon, Mar 6, 2017 at 12:24 AM, Dengke Du <dengke.du at windriver.com> wrote:

> Thanks!
>
> Maybe we should update the commit in linux-yocto_4.8.bb in oe-core.
>


That will happen, just at a slower cadence then me getting the patch into
the tree.

Bruce


>
> Dengke
>
>
>
> On 2017年03月04日 04:14, Bruce Ashfield wrote:
>
>> merged
>>
>> Bruce
>>
>> On 2017-02-27 12:48 AM, Dengke Du wrote:
>>
>>> From: Herbert Xu <herbert at gondor.apana.org.au>
>>>
>>> Upstream commit: 6741f551a0b26479de2532ffa43a366747e6dbf3
>>>
>>> This commit needs to be reverted because it prevents people from
>>> using the serial console as a secondary console with input being
>>> directed to tty0.
>>>
>>> IOW, if you boot with console=ttyS0 console=tty0 then all kernels
>>> prior to this commit will produce output on both ttyS0 and tty0
>>> but input will only be taken from tty0.  With this patch the serial
>>> console will always be the primary console instead of tty0,
>>> potentially preventing people from getting into their machines in
>>> emergency situations.
>>>
>>> Fixes: d03516df8375 ("tty: serial: 8250: add CON_CONSDEV to flags")
>>> Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
>>> Cc: stable <stable at vger.kernel.org>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>>>
>>> Upstream-Status: Backport
>>> Signed-off-by: Dengke Du <dengke.du at windriver.com>
>>> ---
>>>  drivers/tty/serial/8250/8250_core.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/tty/serial/8250/8250_core.c
>>> b/drivers/tty/serial/8250/8250_core.c
>>> index dcf43f6..fa823a5 100644
>>> --- a/drivers/tty/serial/8250/8250_core.c
>>> +++ b/drivers/tty/serial/8250/8250_core.c
>>> @@ -675,7 +675,7 @@ static struct console univ8250_console = {
>>>      .device        = uart_console_device,
>>>      .setup        = univ8250_console_setup,
>>>      .match        = univ8250_console_match,
>>> -    .flags        = CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV,
>>> +    .flags        = CON_PRINTBUFFER | CON_ANYTIME,
>>>      .index        = -1,
>>>      .data        = &serial8250_reg,
>>>  };
>>>
>>>
>>
>>
>


-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/linux-yocto/attachments/20170306/7d1100a2/attachment.html>