[linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

Bruce Ashfield bruce.ashfield at windriver.com
Mon Sep 25 07:28:53 PDT 2017


On 09/22/2017 07:02 PM, akuster808 wrote:
> Cal,
> 
> 
> On 09/22/2017 03:48 PM, California Sullivan wrote:
>> __list_lru_init_key does not exist. We're looking for __list_lru_init as
>> shown in the patch "26690f5 mm: workingset: fix premature shadow node
>> shrinking with cgroups".
>>
>> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
> 
> I believe this fix is already in latest 4.8 preempt-base.
> 
> http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.8/commit/mm/workingset.c?h=standard/preempt-rt/base&id=26690f5a8bdf03966c5db20181089f86f8ca8eef

It was like that, but a merge from standard/base has munged it into
the incorrect form .. and since it is a merge commit, git whatchanged
hides the fact a bit.

I've applied this and pushed it to the -rt branches.

Bruce

> 
> I am working on updating morty to the latest versions.
> 
> - armin
> 
>> ---
>>
>> This is for the standard/preempt-rt/base branch. Standard/base is OK.
>>
>>   mm/workingset.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/workingset.c b/mm/workingset.c
>> index 1856fdb..5e953eb 100644
>> --- a/mm/workingset.c
>> +++ b/mm/workingset.c
>> @@ -493,7 +493,7 @@ static int __init workingset_init(void)
>>   	pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
>>   	       timestamp_bits, max_order, bucket_order);
>>   
>> -	ret = __list_lru_init_key(&__workingset_shadow_nodes, true, &shadow_nodes_key);
>> +	ret = __list_lru_init(&__workingset_shadow_nodes, true, &shadow_nodes_key);
>>   	if (ret)
>>   		goto err;
>>   	ret = register_shrinker(&workingset_shadow_shrinker);
> 
> 



More information about the linux-yocto mailing list