[linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[Cal Sullivan]

On 09/28/2017 07:53 AM, Paul Gortmaker wrote:
> [[linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key] On 22/09/2017 (Fri 15:48) California Sullivan wrote:
>
>> __list_lru_init_key does not exist. We're looking for __list_lru_init as
>> shown in the patch "26690f5 mm: workingset: fix premature shadow node
> I don't have that commit ID in mainline.  I see this:
That commit ID won't be in mainline - it was a backport patch to 4.8.
>
> commit 0cefabdaf757a6455d75f00cb76874e62703ed18
> Author: Johannes Weiner <hannes at cmpxchg.org>
> Date:   Fri Mar 31 15:11:52 2017 -0700
>
>      mm: workingset: fix premature shadow node shrinking with cgroups
>
> Did you perhaps rebase or similar?  Since the patch below is identical
> to the commit above, it is more appropriate to preserve the original
> commit log and authorship, as per how nearly all stable backports are
> handled.
The patch isn't  quite identical: __list_lru_init_key vs list_lru_init_key.
It somehow got mangled in the merge commit 7f56c636.

---
Cal

>
> P.
> --
>
>> shrinking with cgroups".
>>
>> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
>> ---
>>
>> This is for the standard/preempt-rt/base branch. Standard/base is OK.
>>
>>   mm/workingset.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/workingset.c b/mm/workingset.c
>> index 1856fdb..5e953eb 100644
>> --- a/mm/workingset.c
>> +++ b/mm/workingset.c
>> @@ -493,7 +493,7 @@ static int __init workingset_init(void)
>>   	pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
>>   	       timestamp_bits, max_order, bucket_order);
>>   
>> -	ret = __list_lru_init_key(&__workingset_shadow_nodes, true, &shadow_nodes_key);
>> +	ret = __list_lru_init(&__workingset_shadow_nodes, true, &shadow_nodes_key);
>>   	if (ret)
>>   		goto err;
>>   	ret = register_shrinker(&workingset_shadow_shrinker);
>> -- 
>> 2.9.5
>>