[linux-yocto] [PATCH 1/2] driver: of: configfs: fix a building warning
Li, Meng
Meng.Li at windriver.com
Wed Apr 18 21:31:13 PDT 2018
> -----Original Message-----
> From: Bruce Ashfield [mailto:bruce.ashfield at windriver.com]
> Sent: Thursday, April 19, 2018 5:01 AM
> To: Li, Meng
> Cc: linux-yocto at yoctoproject.org
> Subject: Re: [PATCH 1/2] driver: of: configfs: fix a building warning
>
> On 2018-04-18 10:17 AM, Meng.Li at windriver.com wrote:
> > From: Limeng <Meng.Li at windriver.com>
> >
> > Build kernel for arm64 platform, there is a waring as below:
>
> w/waring/warning/
>
> > drivers/of/configfs.c:153:34: note: format string is defined here
> > pr_debug("%s: buf=%p max_count=%u\n", __func__,
> > ~^
> > %lu
> > Because on arm64 platform, size_t is long unsigned int.
> > Therefore, change %u into %zu to compatible with arm
> > and arm64 platform.
>
> Is this a mainline introduced warning, or one that some backported
> patches have introduced ? If we've introduced the warning, we need
> to log the commit ID that introduced it in this commit message. We
> also need to quickly explain why that commit caused the warning.
>
> Same comment for patch 2/2
>
No, there is mainline or backported patches introduce this issue. We introduce the building warning.
The 2 files, configfs.c and intel-service.c are used implement FPGA manager feature.
They are from Intel-PSG(Altera) SDK.
I will send v2 pull request to fix the typo (warning) and add commit ID that introduce issue.
Thanks,
Limeng
> Bruce
>
> >
> > Signed-off-by: Meng Li <Meng.Li at windriver.com>
> > ---
> > drivers/of/configfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/configfs.c b/drivers/of/configfs.c
> > index c7e999c..8490d9c 100644
> > --- a/drivers/of/configfs.c
> > +++ b/drivers/of/configfs.c
> > @@ -150,7 +150,7 @@ ssize_t cfs_overlay_item_dtbo_read(struct
> config_item *item, void *buf,
> > {
> > struct cfs_overlay_item *overlay = to_cfs_overlay_item(item);
> >
> > - pr_debug("%s: buf=%p max_count=%u\n", __func__,
> > + pr_debug("%s: buf=%p max_count=%zu\n", __func__,
> > buf, max_count);
> >
> > if (overlay->dtbo == NULL)
> >
More information about the linux-yocto
mailing list