[linux-yocto] [PATCH 1/1] BSPs: Some required kernel config is not enabled as expected
Hongzhi, Song
hongzhi.song at windriver.com
Thu Sep 6 05:42:09 PDT 2018
On 2018年09月06日 20:29, Bruce Ashfield wrote:
> On 2018-09-06 6:23 AM, Anuj Mittal wrote:
>> On 09/06/2018 06:14 PM, Hongzhi.Song wrote:
>>> The following configs were introduced from SDK, not contained by
>>> kernel. So we should drop them.
>>> CONFIG_X86_INTEL_SBI_APL
>>> CONFIG_SUPPORT_HDMI
>>> CONFIG_INTEL_PMIC_THERMAL
>>> CONFIG_PINCTRL_BAYTRAIL_DEVICE
>>> CONFIG_X86_INTEL_APLI_LHCRB_AIC3107
>>> CONFIG_X86_INTEL_APLI_LHCRB_WM8731
>>> CONFIG_BYT_LPSS_BRD
>>>
>>> Others were removed or the dependencies has been changed by kernel.
>>>
>>> Signed-off-by: Hongzhi.Song <hongzhi.song at windriver.com>
>>> ---
>>> bsp/intel-x86/intel-x86-64.cfg | 7 -------
>>> bsp/intel-x86/intel-x86-acpi.cfg | 1 -
>>> bsp/intel-x86/intel-x86.cfg | 16 ++--------------
>>> features/edac/edac.cfg | 1 -
>>> features/hostapd/hostapd.cfg | 1 -
>>> features/intel-pinctrl/intel-pinctrl.cfg | 2 +-
>>> features/mmc/mmc-block.cfg | 1 -
>>> features/mmc/mmc-realtek.cfg | 2 +-
>>> features/soc/x1000/x1000.cfg | 1 -
>>> features/thermal/coretemp.cfg | 1 +
>>> features/tpm/tpm.cfg | 3 ++-
>>> 11 files changed, 7 insertions(+), 29 deletions(-)
>>>
>>> diff --git a/bsp/intel-x86/intel-x86-64.cfg
>>> b/bsp/intel-x86/intel-x86-64.cfg
>>> index 4e8a4d78..858bf151 100644
>>> --- a/bsp/intel-x86/intel-x86-64.cfg
>>> +++ b/bsp/intel-x86/intel-x86-64.cfg
>>> @@ -1,9 +1,4 @@
>>> #
>>> -# Memory power savings
>>> -#
>>> -CONFIG_I7300_IDLE=m
>>> -
>>> -#
>>> # ACPI NUMA
>>> #
>>> CONFIG_X86_64_ACPI_NUMA=y
>>> @@ -15,7 +10,6 @@ CONFIG_CRYPTO_SHA512_SSSE3=m
>>> # EDAC
>>> CONFIG_EDAC=y
>>> -CONFIG_EDAC_MM_EDAC=m
>>> CONFIG_EDAC_DEBUG=y
>>> CONFIG_EDAC_SBRIDGE=m
>>> CONFIG_ACPI_APEI=y
>>> @@ -34,7 +28,6 @@ CONFIG_PCI_IOV=y
>>> # For Linux Kernel Crypto Framework Sample Driver module over QAT.
>>> #
>>> CONFIG_CRYPTO=y
>>> -CONFIG_CRYPTO_ZLIB=m
>>> CONFIG_CRYPTO_SHA1=y
>>> CONFIG_CRYPTO_HMAC=y
>>> CONFIG_CRYPTO_AES_NI_INTEL=m
>>> diff --git a/bsp/intel-x86/intel-x86-acpi.cfg
>>> b/bsp/intel-x86/intel-x86-acpi.cfg
>>> index dd80f65e..4cfee7e8 100644
>>> --- a/bsp/intel-x86/intel-x86-acpi.cfg
>>> +++ b/bsp/intel-x86/intel-x86-acpi.cfg
>>> @@ -1,5 +1,4 @@
>>> CONFIG_ACPI=y
>>> -CONFIG_ACPI_PROCFS=y
>>> CONFIG_ACPI_PROCFS_POWER=y
>>> CONFIG_ACPI_EC_DEBUGFS=m
>>> CONFIG_ACPI_AC=m
>>> diff --git a/bsp/intel-x86/intel-x86.cfg b/bsp/intel-x86/intel-x86.cfg
>>> index 69191796..e639cf08 100644
>>> --- a/bsp/intel-x86/intel-x86.cfg
>>> +++ b/bsp/intel-x86/intel-x86.cfg
>>> @@ -36,7 +36,6 @@ CONFIG_X86_MCE=y
>>> CONFIG_X86_MCE_INTEL=y
>>> CONFIG_X86_INTEL_LPSS=y
>>> -CONFIG_BYT_LPSS_BRD=y
>>> #
>>> # I2C options
>>> #
>>> @@ -55,7 +54,6 @@ CONFIG_I2C_ISMT=m
>>> # Power management and ACPI options
>>> #
>>> CONFIG_PM=y
>>> -CONFIG_PM_RUNTIME=y
>>> CONFIG_HIBERNATION=y
>>> @@ -81,7 +79,6 @@ GPIO_GENERIC_PLATFORM=m
>>> #
>>> CONFIG_PINCTRL=y
>>> CONFIG_PINCTRL_BAYTRAIL=y
>>> -CONFIG_PINCTRL_BAYTRAIL_DEVICE=y
>>> CONFIG_PINCTRL_BROXTON=m
>>> #
>>> @@ -119,7 +116,6 @@ CONFIG_HOTPLUG_PCI_PCIE=y
>>> CONFIG_MMC=y
>>> CONFIG_MMC_BLOCK=y
>>> CONFIG_MMC_BLOCK_MINORS=8
>>> -CONFIG_MMC_BLOCK_BOUNCE=y
>>> CONFIG_MMC_SDHCI=y
>>> CONFIG_MMC_SDHCI_PCI=y
>>> CONFIG_MMC_SDHCI_ACPI=y
>>> @@ -154,7 +150,6 @@ CONFIG_EEPROM_LEGACY=m
>>> # Intel Wireless WiFi Next Gen AGN
>>> #
>>> # CONFIG_IWLWIFI_DEBUG is not set
>>> -# CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE is not set
>>> CONFIG_IWLDVM=m
>>> CONFIG_IWLMVM=m
>>> CONFIG_HOSTAP=y
>>> @@ -162,7 +157,7 @@ CONFIG_HOSTAP=y
>>> #
>>> # Realtek 8723BE PCI WiFi
>>> #
>>> -CONFIG_R8723BE=m
>>> +CONFIG_RTL8723BE=m
>>> #
>>> # Intel devices
>>> @@ -282,7 +277,6 @@ CONFIG_HSU_DMA_PCI=y
>>> #
>>> CONFIG_SPI_PXA2XX=y
>>> CONFIG_SPI_PXA2XX_PCI=y
>>> -CONFIG_SPI_PXA2XX_DMA=y
>>> CONFIG_VT_HW_CONSOLE_BINDING=y
>>> @@ -318,12 +312,7 @@ CONFIG_NOP_USB_XCEIV=y
>>> # NVMe support
>>> CONFIG_BLK_DEV_NVME=m
>>> -# Sound CODEC
>>> -CONFIG_X86_INTEL_APLI_LHCRB_WM8731=m
>>> -CONFIG_X86_INTEL_APLI_LHCRB_AIC3107=m
>>> -
>>> # Sideband interface
>>> -CONFIG_X86_INTEL_SBI_APL=m
>>> # PMC
>>> CONFIG_INTEL_PMC_IPC=m
>>> @@ -353,14 +342,13 @@ CONFIG_INPUT_TOUCHSCREEN=y
>>> CONFIG_TOUCHSCREEN_ZFORCE=m
>>> # Intel HDMI Audio Support
>>> -CONFIG_SUPPORT_HDMI=y
>>> # NVIDIA GeForce 210
>>> CONFIG_DRM_NOUVEAU=m
>>> CONFIG_DRM_NOUVEAU_BACKLIGHT=y
>>> # Intel RDT support
>>> -CONFIG_INTEL_RDT_A=y
>>> +CONFIG_INTEL_RDT=y
>>> # Intel RAPL
>>> CONFIG_IOSF_MBI=y
>>> diff --git a/features/edac/edac.cfg b/features/edac/edac.cfg
>>> index ad9c98f5..bbe559bf 100644
>>> --- a/features/edac/edac.cfg
>>> +++ b/features/edac/edac.cfg
>>> @@ -12,5 +12,4 @@
>>> #.........................................................................
>>> CONFIG_EDAC=y
>>> -CONFIG_EDAC_MM_EDAC=m
>>> CONFIG_EDAC_DEBUG=y
>>> diff --git a/features/hostapd/hostapd.cfg
>>> b/features/hostapd/hostapd.cfg
>>> index 16c601ea..d1ec38c3 100644
>>> --- a/features/hostapd/hostapd.cfg
>>> +++ b/features/hostapd/hostapd.cfg
>>> @@ -3,7 +3,6 @@
>>> #
>>> CONFIG_CFG80211=y
>>> CONFIG_CFG80211_WEXT=y
>>> -CONFIG_WIRELESS_EXT_SYSFS=y
>>> CONFIG_LIB80211=y
>>> CONFIG_MAC80211=y
>>> CONFIG_RFKILL=y
>>> diff --git a/features/intel-pinctrl/intel-pinctrl.cfg
>>> b/features/intel-pinctrl/intel-pinctrl.cfg
>>> index 7b672b30..1555c5ba 100644
>>> --- a/features/intel-pinctrl/intel-pinctrl.cfg
>>> +++ b/features/intel-pinctrl/intel-pinctrl.cfg
>>> @@ -3,4 +3,4 @@ CONFIG_PINCTRL_BAYTRAIL=y
>>> CONFIG_PINCTRL_CHERRYVIEW=y
>>> CONFIG_PINCTRL_BROXTON=y
>>> CONFIG_PINCTRL=y
>>> -CONFIG_PINCTRL_SUNRISEPOINT=m
>>> +CONFIG_PINCTRL_SUNRISEPOINT=y
>>
>> Could you please explain why this is needed? It doesn't look like
>> anything has changed with respect to this config in kernel.
>>
This is because "CONFIG_PINCTRL_INTEL=y" in intel-pinctrl.cfg is
selected by
CONFIG_PINCTRL_SUNRISEPOINT. If CONFIG_PINCTRL_SUNRISEPOINT is set "m",
CONFIG_PINCTRL_INTEL can not be set "y".
I will make a detail explaination in new patch.
Thanks,
--Hongzhi
>>> diff --git a/features/mmc/mmc-block.cfg b/features/mmc/mmc-block.cfg
>>> index 2b115bd9..31f1f2a1 100644
>>> --- a/features/mmc/mmc-block.cfg
>>> +++ b/features/mmc/mmc-block.cfg
>>> @@ -1,3 +1,2 @@
>>> CONFIG_MMC_BLOCK=y
>>> CONFIG_MMC_BLOCK_MINORS=8
>>> -CONFIG_MMC_BLOCK_BOUNCE=y
>>> diff --git a/features/mmc/mmc-realtek.cfg
>>> b/features/mmc/mmc-realtek.cfg
>>> index 33073255..63bc02c8 100644
>>> --- a/features/mmc/mmc-realtek.cfg
>>> +++ b/features/mmc/mmc-realtek.cfg
>>> @@ -1,2 +1,2 @@
>>> -CONFIG_MFD_RTSX_PCI=m
>>> +CONFIG_MISC_RTSX_PCI=m
>>> CONFIG_MMC_REALTEK_PCI=m
>>> diff --git a/features/soc/x1000/x1000.cfg
>>> b/features/soc/x1000/x1000.cfg
>>> index c3fb230a..0bc84450 100644
>>> --- a/features/soc/x1000/x1000.cfg
>>> +++ b/features/soc/x1000/x1000.cfg
>>> @@ -7,7 +7,6 @@ CONFIG_DMADEVICES=y
>>> #
>>> CONFIG_MMC_BLOCK=y
>>> CONFIG_MMC_BLOCK_MINORS=8
>>> -CONFIG_MMC_BLOCK_BOUNCE=y
>>> #
>>> # MMC/SD/SDIO Host Controller Drivers
>>> diff --git a/features/thermal/coretemp.cfg
>>> b/features/thermal/coretemp.cfg
>>> index 7d24566e..2bec18b6 100644
>>> --- a/features/thermal/coretemp.cfg
>>> +++ b/features/thermal/coretemp.cfg
>>> @@ -14,4 +14,5 @@ CONFIG_INT340X_THERMAL=m
>>> CONFIG_INTEL_POWERCLAMP=m
>>> # Intel PMIC thermal driver
>>> +CONFIG_INTEL_SOC_PMIC_BXTWC=m> CONFIG_INTEL_BXT_PMIC_THERMAL=m
>>> diff --git a/features/tpm/tpm.cfg b/features/tpm/tpm.cfg
>>> index 113f37c7..fc285121 100644
>>> --- a/features/tpm/tpm.cfg
>>> +++ b/features/tpm/tpm.cfg
>>> @@ -1,6 +1,7 @@
>>> # Enable TPM device drivers.
>>> CONFIG_TCG_TPM=y
>>> -CONFIG_HW_RANDOM_TPM=m
>>> +CONFIG_HW_RANDOM=y
>>> +CONFIG_HW_RANDOM_TPM=y
>>>
>>
>> It'd be nice if the features that affect everyone can be in a separate
>> commit message.
>
> Agreed. These should be split into small commits so we have more
> granularity for review and logging.
>
> Bruce
>
Ok, I will separate it into three commits.
--Hongzhi
>>
>> Thanks,
>> Anuj
>>
>
>
More information about the linux-yocto
mailing list