[linux-yocto] [PATCH] Revert "fuse: require /dev/fuse reads to have enough buffer capacity"
Bruce Ashfield
bruce.ashfield at gmail.com
Mon Jun 24 08:21:55 PDT 2019
I had queued -rc6 this morning .. and then noticed this.
I've pushed the changes, so we are covered, now that the -dev kernel is updated.
Bruce
On Mon, Jun 24, 2019 at 5:39 AM <zhe.he at windriver.com> wrote:
>
> From: Miklos Szeredi <mszeredi at redhat.com>
>
> This reverts commit d4b13963f217dd947da5c0cabd1569e914d21699.
>
> The commit introduced a regression in glusterfs-fuse.
>
> Reported-by: Sander Eikelenboom <linux at eikelenboom.it>
> Signed-off-by: Miklos Szeredi <mszeredi at redhat.com>
> ---
> This fixes failure to mount glusterfs and is from v5.2-rc6.
> If we're not going to merge v5.2-rc6 soon, please kindly consider merging this
> first, thanks.
>
> fs/fuse/dev.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 24ea19c..ea82375 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -1317,16 +1317,6 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file,
> unsigned reqsize;
> unsigned int hash;
>
> - /*
> - * Require sane minimum read buffer - that has capacity for fixed part
> - * of any request header + negotated max_write room for data. If the
> - * requirement is not satisfied return EINVAL to the filesystem server
> - * to indicate that it is not following FUSE server/client contract.
> - * Don't dequeue / abort any request.
> - */
> - if (nbytes < max_t(size_t, FUSE_MIN_READ_BUFFER, 4096 + fc->max_write))
> - return -EINVAL;
> -
> restart:
> spin_lock(&fiq->waitq.lock);
> err = -EAGAIN;
> --
> 2.7.4
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
More information about the linux-yocto
mailing list