[linux-yocto] [kernel v5.2/standard/xlnx-soc][PATCH 2/2] arm: dts: zynq: update coresight device node

[qwang2]

On 10/9/19 9:39 PM, Michal Simek wrote:
> Hi,
>
> On 09. 10. 19 4:38, quanyang.wang at windriver.com wrote:
>> From: Quanyang Wang <quanyang.wang at windriver.com>
>>
>> Using new compatible value for funnel and replicator device nodes,
>> and use correct unit-address.
>>
>> Signed-off-by: Quanyang Wang <quanyang.wang at windriver.com>
>> ---
>>   arch/arm/boot/dts/zynq-7000.dtsi | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 5602f4f3ad1c..9b8f46d25d38 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -447,8 +447,8 @@
>>   			};
>>   		};
>>   
>> -		funnel at 0,f8804000 {
>> -			compatible = "arm,coresight-funnel", "arm,primecell";
>> +		funnel at f8804000 {
>> +			compatible = "arm,coresight-static-funnel", "arm,primecell";
>>   			reg = <0xf8804000 0x1000>;
>>   			clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
>>   			clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
>> @@ -503,7 +503,7 @@
>>   		};
>>   
>>   		replicator {
>> -			compatible = "arm,coresight-replicator";
>> +			compatible = "arm,coresight-static-replicator";
>>   			clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
>>   			clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
>>   
>> @@ -536,8 +536,8 @@
>>   			};
>>   		};
>>   
>> -		itm at 0,f8805000 {
>> -			compatible = "arm,coresight-etm3x", "arm,primecell";
>> +		/* ITM is not supported by kernel, only leave device node here */
>> +		itm at f8805000 {
>>   			reg = <0xf8805000 0x1000>;
>>   			clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
>>   			clock-names = "apb_pclk", "dbg_trc", "dbg_apb";
>> @@ -549,7 +549,7 @@
>>   			};
>>   		};
>>   
>> -		ptm at 0,f889c000 {
>> +		ptm at f889c000 {
>>   			compatible = "arm,coresight-etm3x", "arm,primecell";
>>   			reg = <0xf889c000 0x1000>;
>>   			clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
>> @@ -562,7 +562,7 @@
>>   			};
>>   		};
>>   
>> -		ptm at 0,f889d000 {
>> +		ptm at f889d000 {
>>   			compatible = "arm,coresight-etm3x", "arm,primecell";
>>   			reg = <0xf889d000 0x1000>;
>>   			clocks = <&clkc 27>, <&clkc 46>, <&clkc 47>;
>>
>
> I don't think this is enough. I have attached the patch against mainline
> how I think it should look like.

Hi Michal,

Will ITM still use "arm,coresight-etm3x" as compatible property?

Thanks,

Quanyang

>
> M
>