[meta-ti] [PATCH 1/2] sdcard_image bbclass: fix MLO copy, loop device mounts, fstypes

[Peter Bigot]

On Sun, Nov 13, 2011 at 12:42 PM, Koen Kooi <koen at dominion.thruhere.net> wrote:
>
> Op 13 nov. 2011, om 19:25 heeft Peter A. Bigot het volgende geschreven:
>
>> From: "Peter A. Bigot" <bigotp at acm.org>
>>
>> Generalize the search for MLO to install to have correct path for copies
>> placed in ${DEPLOY_DIR_IMAGE} by x-load.inc, and to continue for SPL builds
>> where there is no MLO.
>>
>> Allow user to override the loop mount point as well as the loop device, for
>> folks who don't want long paths to temporary directories in their fstabs.
>>
>> Add noauto to example fstab entries so systems will boot without attempting
>> to mount an unconfigured loopback device.
>>
>> Remove IMAGE_FSTYPE_append which does not belong in this class.
>
> I like the fstab changes, but not the others, could you please split this patch?

So I can prepare more appropriate patches now and in the future, please explain:

* Why do you want to hard-code the MLO symlink paths in the install
and deploy directories instead of using the bitbake variables that
x-load.inc uses for those paths?

* Why do you want IMAGE_FSTYPE to be extended with .tar.bz2 when this
class has nothing to do with tar.bz2 images?

* Why do you want IMAGE_FSTYPE to be set in the class when every other
image recipe in openembedded puts IMAGE_FSTYPE modifications in the
recipe that incorporates the image?

Thanks.

Peter

>
> regards,
>
> Koen
> -----BEGIN PGP SIGNATURE-----
>
> iEYEARECAAYFAk7AD4IACgkQMkyGM64RGpGW8gCgrK/QEYtpHxYDuOHPuONYeJlv
> TZgAmQGlt/0ZCZoRvbNbqUpCr6QpT0P3
> =Az4V
> -----END PGP SIGNATURE-----
>
>