[meta-ti] [Angstrom-devel] [PATCH meta-ti] sdcard_image: Copy user.txt/uEnv.txt if it exists in /boot

[Joel A Fernandes]

>>>>
>>>> Signed-off-by: Joel A Fernandes <joelagnel at ti.com>
>>>> ---
>>>> classes/sdcard_image.bbclass |    4 +++-
>>>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/classes/sdcard_image.bbclass b/classes/sdcard_image.bbclass
>>>> index ed9d779..c535ad2 100644
>>>> --- a/classes/sdcard_image.bbclass
>>>> +++ b/classes/sdcard_image.bbclass
>>>> @@ -86,8 +86,10 @@ IMAGE_CMD_sdimg () {
>>>>               suffix=bin
>>>>       fi
>>>>
>>>> +     cp -v ${IMAGE_ROOTFS}/boot/{user.txt,uEnv.txt} ${WORKDIR}/tmp-mnt-boot || true
>>>> +
>>>>       if [ -e ${IMAGE_ROOTFS}/boot/u-boot.$suffix ] ; then
>>>> -             cp -v ${IMAGE_ROOTFS}/boot/{u-boot.$suffix,user.txt,uEnv.txt} ${WORKDIR}/tmp-mnt-boot || true
>>>> +             cp -v ${IMAGE_ROOTFS}/boot/{u-boot.$suffix} ${WORKDIR}/tmp-mnt-boot || true
>>>
>>> Your patch is effectively a noop, I don't see the value in applying it.
>>>
>>
>> There is quite a lot of value in applying it.
>>
>> I suggest you try to build an image (cloud9 / ti-hw-bringup) and
>> notice that there is no uEnv.txt in the boot partition.
>
> If you're fixing the bug that {1,2,3} will only pick 1, but forget 2,3 then user.txt is still broken. If you're saying uboot.suffix is not in /boot, we need to fix that. Either way, I'm not supposed to be guessing that, you should explain that in the commit message or with comments in the code or both.
>

Please let the sdcard class copy the U-boot environment files (as it
originally was) from /boot to the boot partition and not make it
conditional on the presence of anything else.

Joel