[meta-ti] [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Maupin, Chase]

> -----Original Message-----
> From: meta-ti-bounces at yoctoproject.org [mailto:meta-ti-
> bounces at yoctoproject.org] On Behalf Of Koen Kooi
> Sent: Wednesday, August 01, 2012 10:59 PM
> To: Cooper Jr., Franklin
> Cc: meta-ti at yoctoproject.org
> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
> interfaces file from oe-classic
> 
> Please send patches inline to make review easier.
> 
> Patch 1:
> 
> > * Add PR_append
> 
> Don't do that, that's what PRINC is for
> 
> > * Pull in the base interface file from oe-core
> 
> Completely unneeded

I actually prefer that the first commit move in the base file he
is modifying and then have the second commit make his changes.
It is much easier to understand what change he was making to the
base file and why he needing to overlay it.

> 
> > * Update to use the new syntax for extending the file search
> path
> 
> Patch 2:
> 
> > Update interface file based on changes made to the interface
> file
>   in arago
> 
> THe interfaces file is supposed to be machine specific, so a "one
> file to rule them all" is completely unacceptable in meta-ti. If
> you want to go such a route, do it in meta-arago. Even so, I
> strongly recommend against that.
> 
> Op 1 aug. 2012, om 21:07 heeft "Cooper Jr., Franklin"
> <fcooper at ti.com> het volgende geschreven:
> 
> > Attached patches are for porting the netbase interface file
> used in arago/oe-classic to meta-ti.
> >
> > The difference between my interfaces file and the one in
> beagleboard directory seems very minor. Would it be ok to combine
> the changes from both files into a single file? The auto usb0
> looks like it might be an issue if we combined the two files.
> Would it make sense to append that line to the interface file
> during do_install_append step only for the beagleboard platform
> and consolidate the rest of the differences?
> >
> > diff beagleboard/interfaces interfaces
> > 13a14,17
> > > iface tiwlan0 inet dhcp
> > >    wireless_mode managed
> > >    wireless_essid any
> > >
> > 18a23,24
> > >         pre-up /bin/grep -v -e "ip=[0-9]\+\.[0-9]\+\.[0-
> 9]\+\.[0-9]\+" /proc/cmdline > /dev/null
> > >
> > 21,22c27,28
> > < # Ethernet/RNDIS gadget (g_ether) or LAN9514 on BeagleBoard
> xM
> > < auto usb0
> > ---
> > > # Ethernet/RNDIS gadget (g_ether)
> > > # ... or on host side, usbnet and random hwaddr
> >
> >
> > Regards,
> > Franklin Cooper Jr.
> > Texas Instruments
> > Application Engineer
> > fcooper at ti.com
> >
> > <0001-netbase-Add-base-interface-file.patch><0002-netbase-
> Update-interface-
> file.patch>_______________________________________________
> > meta-ti mailing list
> > meta-ti at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti