[meta-ti] [branch: master][PATCHES] Porting netbase interfaces file from oe-classic

[Denys Dmytriyenko]

On Thu, Aug 02, 2012 at 05:07:36PM +0200, Koen Kooi wrote:
> 
> Op 2 aug. 2012, om 16:53 heeft "Maupin, Chase" <chase.maupin at ti.com> het volgende geschreven:
> 
> >> -----Original Message-----
> >> From: meta-ti-bounces at yoctoproject.org [mailto:meta-ti-
> >> bounces at yoctoproject.org] On Behalf Of Koen Kooi
> >> Sent: Wednesday, August 01, 2012 10:59 PM
> >> To: Cooper Jr., Franklin
> >> Cc: meta-ti at yoctoproject.org
> >> Subject: Re: [meta-ti] [branch: master][PATCHES] Porting netbase
> >> interfaces file from oe-classic
> >> 
> >> Please send patches inline to make review easier.
> >> 
> >> Patch 1:
> >> 
> >>> * Add PR_append
> >> 
> >> Don't do that, that's what PRINC is for
> >> 
> >>> * Pull in the base interface file from oe-core
> >> 
> >> Completely unneeded
> > 
> > I actually prefer that the first commit move in the base file he
> > is modifying and then have the second commit make his changes.
> > It is much easier to understand what change he was making to the
> > base file and why he needing to overlay it.
> 
> My point is that you're now *globally* modifying basefiles for *all* 
> machines, including non-TI ones as soon as you have meta-ti in the layer 
> stack, which is unacceptable. If you really want a catch-all interfaces 
> file, put it in meta-arago.

FYI, after discussing this internally, we agreed to not modify basefiles 
globally, but rather provide SOC-specific version where possible, or even 
machine-specific, when needed. In this particular case, we'll have a 
ti33x-specific interfaces file, which will be overwritten by 
beaglebone-specific one. PRINC should also be used in meta-ti bbappends.

Franklin, will you be resending the updated patch?

-- 
Denys