[meta-ti] [PATCH] gadget init: don't dump info to info.txt on boot

Jason Kridner jkridner at beagleboard.org
Wed Mar 7 07:20:40 PST 2012


On Wednesday, March 7, 2012, Koen Kooi wrote:

> This script adds ~10s to the boot time, doesn't have error checking and
> prevents loading the storage gadget 3 out of 10 times.
>

What is the root cause?  Would it be better to add error checking?


>
> Remove it from ExecStartPre to get a fast, consistent boot. The
> functionality should be moved to bone101.
>

If the drive is already mounted, is it valid to edit this file?  (I would
think not.)


>
> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net <javascript:;>>
> ---
>  recipes-ti/beagleboard/gadget-init.bb              |    2 +-
>  .../gadget-init/storage-gadget-init.service        |    1 -
>  2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-ti/beagleboard/gadget-init.bbb/recipes-ti/beagleboard/
> gadget-init.bb
> index 016877d..1a6a336 100644
> --- a/recipes-ti/beagleboard/gadget-init.bb
> +++ b/recipes-ti/beagleboard/gadget-init.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Units to initialize usb gadgets"
>
> -PR = "r18"
> +PR = "r19"
>
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58"
> diff --git
> a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> index 601e0d7..9a8513e 100644
> --- a/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> +++ b/recipes-ti/beagleboard/gadget-init/storage-gadget-init.service
> @@ -4,7 +4,6 @@ After=dev-mmcblk0p1.device
>
>  [Service]
>  RemainAfterExit=yes
> -ExecStartPre=/usr/bin/update-image-info-on-mmcblk0p1.sh
>  ExecStart=/sbin/modprobe g_mass_storage file=/dev/mmcblk0p1 cdrom=0
> stall=0 removable=1 nofua=1
>  ExecStop=/sbin/rmmod g_mass_storage
>
> --
> 1.7.2.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-ti/attachments/20120307/3aff053c/attachment.html>


More information about the meta-ti mailing list