[meta-ti] [PATCH 4/4] am335x-evm.conf: Add 'ubi' to IMAGE_FSTYPES

Koen Kooi koen at dominion.thruhere.net
Fri Mar 9 10:38:00 PST 2012


Op 9 mrt. 2012, om 16:54 heeft Tom Rini het volgende geschreven:

> On Fri, Mar 09, 2012 at 07:16:22AM +0100, Koen Kooi wrote:
>> 
>> Op 8 mrt. 2012, om 20:34 heeft Tom Rini het volgende geschreven:
>> 
>>> We also change to using '+=' not '?=' with IMAGE_FSTYPES and add the
>>> required MKUBIFS_ARGS / UBINIZE_ARGS.  These are placed next to the
>>> line that sets us to use the PSP kernel tree and reference the TI wiki
>>> for the source of our info.
>> 
>> The OE classic way of documenting is a lot better and doesn't rely on
>> wiki pages but on the submitter actually checking the output of the
>> commands. So please use the old style way of documenting the params.
> 
> I disagree here.  The wiki page here

It is still external documentation for things that people will get wrong

> has the calculations as to why the
> erase size is 126976 whereas just doing ubiattach will only print out
> the in-use value.  How about adding a line about verifying these with
> ubiattach or dmesg ?

That would be best. I should only need the machine.conf and the target board to figure out ubi params, not some random wiki


More information about the meta-ti mailing list