[meta-ti] [PATCHv2] abefw: Firmware for OMAP5 ABE

[Cooper Jr., Franklin]

Only one real comment below but overall looks good

On Aug 21, 2013, at 6:48 AM, "Hingolikar, Mrinmayee" <mrinmayee at ti.com> wrote:

> Ping for comments!
> 
>> -----Original Message-----
>> From: Hingolikar, Mrinmayee
>> Sent: Wednesday, July 03, 2013 4:32 PM
>> To: meta-ti at yoctoproject.org
>> Cc: Hingolikar, Mrinmayee; Heroor, Siddharth
>> Subject: [PATCHv2] abefw: Firmware for OMAP5 ABE
>> 
>> * The OMAP5 Audio Backend requires a 'firmware' to enable
>>  sound. This recipe installs a prebuilt firmware. This
>>  part is a hack, as in the current form, the firmware
>>  cannot be cross-compiled. There is a plan to fix this
>>  and hopefully, this recipe is short-lived. Once the code
>>  is fixed, we should have new recipes that build the firmware
>>  and clean up this recipe.
>> 
>> v2:
>> * Merged contents from abefw.inc and removed abefw.inc based
>>  on review.
>> 
>> Signed-off-by: Mrinmayee Hingolikar <mrinmayee at ti.com>
>> Signed-off-by: Siddharth Heroor <heroor at ti.com>
>> ---
>> recipes-bsp/abefw/abefw_1.0.14.bb |   20 ++++++++++++++++++++
>> 1 files changed, 20 insertions(+), 0 deletions(-)  create mode 100644
>> recipes-bsp/abefw/abefw_1.0.14.bb
>> 
>> diff --git a/recipes-bsp/abefw/abefw_1.0.14.bb b/recipes-
>> bsp/abefw/abefw_1.0.14.bb
>> new file mode 100644
>> index 0000000..8db71e4
>> --- /dev/null
>> +++ b/recipes-bsp/abefw/abefw_1.0.14.bb
>> @@ -0,0 +1,20 @@
>> +SUMMARY = "Firmware for OMAP5 ABE"
>> +HOMEPAGE = "http://git.ti.com"
Not a big deal but probably should use the git.ti link to the actual repository so people can find it easier"
>> +LICENSE = "BSD/GPLv2"
This should be "BSD | GPLv2"
>> +LIC_FILES_CHKSUM =
>> "file://COPYING;md5=923db086ed9463ab3215b24d87e05ec5"
>> +
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +COMPATIBLE_MACHINE = "omap5-evm"
>> +
>> +SRC_URI = "git://git.ti.com/glsdk/abefw-omap4plus.git;protocol=git"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +SRCREV = "ceccc0332264e39bdc51e54f80ea7256a3886c58"
>> +
>> +do_install() {
>> +        mkdir -p ${D}/lib/firmware
>> +        cp ${S}/firmware/omap4_abe_new ${D}/lib/firmware/ }
>> +
>> +FILES_${PN} += "/lib/firmware/omap4_abe_new"
>> --
>> 1.7.0.4
> 
> _______________________________________________
> meta-ti mailing list
> meta-ti at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti