[meta-ti] mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header

[Peter A. Bigot]

On 12/26/2014 09:49 AM, Christian d'Heureuse wrote:
> Hi Peter
>
> I stumbled on the same error in am33xx.h as you described in September:
> https://lists.yoctoproject.org/pipermail/meta-ti/2014-September/005211.html 
>
>
> Did you get any reactions?

Just the follow-up theorizing it'd been fixed upstream.  As of today, 
it's still wrong in both am33xx.h and am43xx.h when "upstream" means the 
torvalds master branch.

I keep hoping a TIer will step up, but if not I suppose somebody else 
has to do it.

Maybe E2E will yield results. 
http://e2e.ti.com/support/arm/sitara_arm/f/791/p/367445/1382229#1382229

Peter

>
> The error is still in the current Linux source:
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/include/dt-bindings/pinctrl/am33xx.h 
>
>
> #define SLEWCTRL_FAST           (1 << 6)
>
> In the old Rowboat kernel, the definition was correct:
>
> https://gitorious.org/rowboat/kernel/source/03f2a1e9ea7f8b11ff6809f5a75b614011f8adb6:arch/arm/mach-omap2/mux.h 
>
>
> #define AM33XX_SLEWCTRL_FAST            (0 << 6)
> #define AM33XX_SLEWCTRL_SLOW            (1 << 6)
>
> An in the AM335X Technical Reference Manual
> http://www.ti.com/lit/ug/spruh73k/spruh73k.pdf
> "slewctrl" bit:
> "9.2.2 Pad Control Registers"
> "9.3.1.50 conf_<module>_<pin> Register"
>
> According to 
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/include/dt-bindings/pinctrl/am33xx.h 
> the author is
> Florian Vaussard <florian.vaussard at epfl.ch> and the committer is 
> Benoit Cousson <benoit.cousson at linaro.org>. Maybe we could write one 
> of them?
>
> Christian
> http://www.source-code.biz  http://www.inventec.ch/chdh