[meta-ti] [PATCH v2 1/2] common-csl-ip: (ti-csl) Moved from meta-arago and renamed

[Denys Dmytriyenko]

Ah, never mind the whitespaces - I forgot that you are fixing them in the 
second patch, while the first one is just an exact copy of the exisitng 
recipe... :) My bad, sorry. I'll only fix lost SOB then.


On Tue, Oct 07, 2014 at 03:36:57PM -0400, Denys Dmytriyenko wrote:
> And few more comments for the future (I'll fix those for now):
> 
> 
> On Tue, Oct 07, 2014 at 07:36:44AM -0400, Sam Nelson wrote:
> > - Moved from meta-arago ( where it was called ti-csl_git.bb)
> >   http://arago-project.org/git/?p=meta-arago.git;a=blob_plain;f=meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb;hb=HEAD
> > - Renamed it to common-csl-ip_git.bb
> > - This package provides chip support library interface files
> > 
> > ---
> > Changes from previous version of patch
> > -Add comments on renaming and original url attached
> > - rename to common-csl-ip_git.bb
> > ---
> 
> Your SOB line gets lost, as it appears after the '---' delimiter.
> The above "Changes" section should be after the SOB line below, as everything 
> between the first '---' and 'diff' lines gets ignored.
> 
> 
> > Signed-off-by: Sam Nelson <sam.nelson at ti.com>
> > ---
> 
> I usually write patch revision changes here...
> 
> 
> >  recipes-bsp/common-csl-ip/common-csl-ip_git.bb |   21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >  create mode 100644 recipes-bsp/common-csl-ip/common-csl-ip_git.bb
> > 
> > diff --git a/recipes-bsp/common-csl-ip/common-csl-ip_git.bb b/recipes-bsp/common-csl-ip/common-csl-ip_git.bb
> > new file mode 100644
> > index 0000000..fb5e6f8
> > --- /dev/null
> > +++ b/recipes-bsp/common-csl-ip/common-csl-ip_git.bb
> > @@ -0,0 +1,21 @@
> > +DESCRIPTION = "TI CSL"
> > +LICENSE = "TI BSD"
> > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
> > +
> > +COMPATIBLE_MACHINE = "keystone"
> > +ALLOW_EMPTY_${PN} = "1"
> > +
> > +PR = "r0"
> > +BRANCH="master"
> > +SRC_URI = "git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"
> > +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17
> > +SRCREV = "f6f90144c14e1ee783c4b893b52e54830be8166e" 
> 
> ^^^ git-am complains there's a trailing whitespace at the end of SRCREV line.
> 
> 
> > +S = "${WORKDIR}/git"
> > +
> > +do_install () {
> > +    install -d ${D}${includedir}/ti/csl
> > +    find . -name "*.h" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl 
> 
> ^^^ As well as the first "find" command line has trailing whitespace.
> 
> 
> > +    find ./src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl
> > +}
> > +
> 
> ^^^ Another complaint from git-am is the blank line at the end of the file.
> 
> 
> Applying: common-csl-ip: (ti-csl) Moved from meta-arago and renamed
> /OE/arago-daisy/sources/meta-ti/.git/rebase-apply/patch:30: trailing whitespace.
> SRCREV = "f6f90144c14e1ee783c4b893b52e54830be8166e" 
> /OE/arago-daisy/sources/meta-ti/.git/rebase-apply/patch:36: trailing whitespace.
>     find . -name "*.h" -type f | xargs -I {} cp --parents {} 
> ${D}${includedir}/ti/csl 
> /OE/arago-daisy/sources/meta-ti/.git/rebase-apply/patch:39: new blank line at EOF.
> +
> warning: 3 lines add whitespace errors.
> 
> 
> > -- 
> > 1.7.9.5
> > 
> > -- 
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti