[meta-ti] [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES

[Cooper Jr., Franklin]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Friday, September 26, 2014 3:55 PM
> To: Cooper Jr., Franklin
> Cc: Stiffler, Jacob; meta-ti at yoctoproject.org
> Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to
> MACHINE_FEATURES
> 
> On Fri, Sep 26, 2014 at 08:33:39PM +0000, Cooper Jr., Franklin wrote:
> > So this patch shouldn't be needed.
> >
> > The only recipe that is using mmip is ipumm-fw. Currently the recipe
> > has COMPATIBLE_MACHINE set to only omap-a15. So why do we also
> need to
> > add this to the SOC family?
> 
> The above statement is not correct.
> 
> The flag mmip in MACHINE_FEATURES was introduced to handle cases of
> hardware accelerated multimedia, when some software components needs
> to be replaced with "forked" patched and modified versions. Take a look at
> gstreamer pieces in meta-arago...
[Franklin] Ah. My grep was only in meta-ti  I missed the usage in meta-arago.
> 
> 
> > Honestly for ipumm-fw the below code should be removed.
> > python __anonymous() {
> >      features = bb.data.getVar("MACHINE_FEATURES", d, 1)
> >      if not features:
> >          return
> >      if "mmip" not in features:
> >          raise bb.parse.SkipPackage('ipumm-fw does not apply to
> > systems without the "mmip" flag in MACHINE_FEATURES')  }
> >
> > Plus this patch will break things for am57xx-evm. By allowing this
> > change ipumm-fw would not be skipped for am57x evm and the current
> > recipe will fail because of it.
> 
> So, am57xx-evm should not build and load ipumm-fw is what you are saying?
[Franklin] I didn't realize that dra7xx was used for am57x-evm. So it will build.

So this patch is fine but I'm still pretty confused by the usage of mmip. Now that mmip is added to omap-a15 SOC family can we now remove skip package code from all the various recipes that use mmip and simply replace it with COMPATIBLE_MACHINE?

> 
> --
> Denys
> 
> 
> > > -----Original Message-----
> > > From: meta-ti-bounces at yoctoproject.org [mailto:meta-ti-
> > > bounces at yoctoproject.org] On Behalf Of Stiffler, Jacob
> > > Sent: Wednesday, September 24, 2014 9:42 AM
> > > To: meta-ti at yoctoproject.org
> > > Subject: Re: [meta-ti] [daisy][PATCH] dra7xx: add "mmip" to
> > > MACHINE_FEATURES
> > >
> > > ping
> > >
> > > -----Original Message-----
> > > From: Stiffler, Jacob
> > > Sent: Monday, September 15, 2014 8:32 AM
> > > To: meta-ti at yoctoproject.org
> > > Cc: Stiffler, Jacob
> > > Subject: [daisy][PATCH] dra7xx: add "mmip" to MACHINE_FEATURES
> > >
> > > Signed-off-by: Jacob Stiffler <j-stiffler at ti.com>
> > > ---
> > >  conf/machine/include/dra7xx.inc |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/conf/machine/include/dra7xx.inc
> > > b/conf/machine/include/dra7xx.inc index 857e1b3..a7c8782 100644
> > > --- a/conf/machine/include/dra7xx.inc
> > > +++ b/conf/machine/include/dra7xx.inc
> > > @@ -1,4 +1,4 @@
> > >  require conf/machine/include/omap-a15.inc  SOC_FAMILY_append =
> > > ":dra7xx"
> > >
> > > -MACHINE_FEATURES += "pci"
> > > +MACHINE_FEATURES += "pci mmip"
> > > --
> > > 1.7.9.5
> > >
> > > --
> > > _______________________________________________
> > > meta-ti mailing list
> > > meta-ti at yoctoproject.org
> > > https://lists.yoctoproject.org/listinfo/meta-ti
> > --
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti