[meta-ti] Denys Dmytriyenko : setup-defconfig: support combined?defconfig with listed config fragments
Denys Dmytriyenko
denys at ti.com
Fri Jan 9 08:03:20 PST 2015
On Fri, Jan 09, 2015 at 09:58:10AM +0000, Francesco Del Degan wrote:
> Arago Project git <git at ...> writes:
>
> > + config=`cat ${S}/.config | grep config-fragment | cut -d= -f2`
> > + if [ -n "$config" ]
> > + then
> > + configfrags=""
> > + for f in $config
> > + do
> > + # Check if the config fragment is available
> > + if [ ! -e "$f" ]
> > + then
> > + echo "Could not find kernel config fragment $f"
> > + exit 1
> > + else
> > + # Sanitize config fragment files to be relative to
> sources
> > + configfrags+=" ${S}/$f"
> > + fi
> > + done
> > + fi
> > +
>
> Hi,
>
> I think that configfrags+="..." here is a bashism. It fails on my builder
> with "configfrags+= ..... not found".
>
> I resolved with configfrags="$configfrags ${S}/$f"
Thanks. I'll fix it.
There are many more bashisms in other places, so I'm not specifically looking
for them...
--
Denys
More information about the meta-ti
mailing list