[meta-ti] [RFC PATCH 4/6] opencl-monitor: OpenCL firmware which runs on the accelerators.

[Cooper Jr., Franklin]

> On Mar 3, 2015, at 7:54 AM, Stiffler, Jacob <j-stiffler at ti.com> wrote:
> 
> I've seen conflicting suggestions about manually setting the PR = "r0". I can add this, but how should this interact with the .inc file? I assume that either the inc file or bb recipe should append a value, so should the recipe make the append?

Manually setting PR = "r0" isn't technically required but it doesn't hurt anything.

When you have inc files like ocl.inc that may be reused by several recipes generally you set the PR in the include file and use PR_inc (something like that) within the recipes. PR inc essentially sets the recipe PR to    PR + PR inc = recipe PR.  This way when you make changes to the include file and bump the PR all recipes that depend on the inc file are automatically bumped.

Look at some of the Matrix apps recipes
> 
> 
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Thursday, February 26, 2015 10:17 AM
> To: Dmytriyenko, Denys
> Cc: Stiffler, Jacob; meta-ti at yoctoproject.org
> Subject: RE: [meta-ti] [RFC PATCH 4/6] opencl-monitor: OpenCL firmware which runs on the accelerators.
> 
> 
> 
>> -----Original Message-----
>> From: Dmytriyenko, Denys
>> Sent: Thursday, February 26, 2015 9:17 AM
>> To: Cooper Jr., Franklin
>> Cc: Stiffler, Jacob; meta-ti at yoctoproject.org
>> Subject: Re: [meta-ti] [RFC PATCH 4/6] opencl-monitor: OpenCL firmware 
>> which runs on the accelerators.
>> 
>>> On Thu, Feb 26, 2015 at 02:02:22PM +0000, Cooper Jr., Franklin wrote:
>>> Mesa as a whole as a MIT license based on the recipe. Looking at the 
>>> license for those headers your using they are also using a MIT 
>>> license. So this program should have a BSD and MIT license.
>>> Also your missing a PR which I think Denys still wants to include 
>>> for package upgrading purposes. But it's up to him.
>> 
>> But this one is not an upgrade, so not sure why do you need a PR?
> [Franklin] Without a PR people tend to forget to bump it.
>> 
>> 
>>>> -----Original Message-----
>>>> From: meta-ti-bounces at yoctoproject.org [mailto:meta-ti- 
>>>> bounces at yoctoproject.org] On Behalf Of Stiffler, Jacob
>>>> Sent: Thursday, February 26, 2015 7:34 AM
>>>> To: meta-ti at yoctoproject.org
>>>> Subject: [meta-ti] [RFC PATCH 4/6] opencl-monitor: OpenCL firmware 
>>>> which runs on the accelerators.
>>>> 
>>>> Signed-off-by: Jacob Stiffler <j-stiffler at ti.com>
>>>> ---
>>>> recipes-ti/ocl/opencl-monitor_git.bb |   41
>>>> ++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 41 insertions(+)
>>>> create mode 100644 recipes-ti/ocl/opencl-monitor_git.bb
>>>> 
>>>> diff --git a/recipes-ti/ocl/opencl-monitor_git.bb
>>>> b/recipes-ti/ocl/opencl- monitor_git.bb new file mode 100644 index
>>>> 0000000..54b3f45
>>>> --- /dev/null
>>>> +++ b/recipes-ti/ocl/opencl-monitor_git.bb
>>>> @@ -0,0 +1,41 @@
>>>> +DESCRIPTION = "TI OpenCL"
>>>> +HOMEPAGE = "https://gitorious.design.ti.com/ocl"
>>>> +LICENSE = "BSD"
>>>> +
>>>> +include ocl.inc
>>>> +
>>>> +inherit cmake
>>>> +
>>>> +COMPATIBLE_MACHINE = "dra7xx"
>>>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>>>> +
>>>> +SRC_URI_append = " \
>>>> +    ${SRC_URI_OPENCL} \
>>>> +    ${SRC_URI_MONITOR} \
>>>> +    ${SRC_URI_BUILTINS} \
>>>> +    ${SRC_URI_LIBM} \
>>>> +    ${SRC_URI_MONITOR_IMAGE} \
>>>> +    ${MONITOR_PATCHES} \
>>>> +    ${OPENCL_PATCHES} \
>>>> +    ${OPENGL_HEADERS} \
>>>> +"
>>>> +
>>>> +S = "${WORKDIR}/git/opencl_monitor"
>>>> +
>>>> +
>>>> +do_compile_append() {
>>>> +    cp -rv ${WORKDIR}/opencl_monitor-vayu-0.12.0/* ${S}/ }
>>>> +
>>>> +do_install_append() {
>>>> +    cp -v ${D}${datadir}/ti/opencl/dsp0.out
>> ${D}${datadir}/ti/opencl/dsp.out
>>>> +    cp -v ${D}${datadir}/ti/opencl/dsp0.syms
>>>> +${D}${datadir}/ti/opencl/dsp.syms }
>>>> +
>>>> +FILES_${PN} += " \
>>>> +    ${datadir}/ti/opencl/* \
>>>> +    ${base_libdir}/firmware/* \
>>>> +"
>>>> +
>>>> +INSANE_SKIP_${PN} = "arch"
>>>> +
>>>> --
>>>> 1.7.9.5
>>>> 
>>>> --
>>>> _______________________________________________
>>>> meta-ti mailing list
>>>> meta-ti at yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/meta-ti
>>> --
>>> _______________________________________________
>>> meta-ti mailing list
>>> meta-ti at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-ti