[meta-ti] [RFC PATCH 1/6] opencl: Add common file specifying opencl sources and version.

Tue Mar 3 07:05:17 PST 2015



> On Mar 3, 2015, at 7:47 AM, Stiffler, Jacob <j-stiffler at ti.com> wrote:
> 
> There are shared sources within these repos, but not every recipe requires all of the sources.
> 
> As for the circular patch dependencies: Would it make sense to separate the opengl headers into a separate recipe, and keep that one self-contained?
Well no matter what you do the headers should exist either as plain files or recipe before being referenced by this recipe. So you can easily just  split from the other patch where your adding the headers and put it in its own patch before this one. 
> Also, I plan on upstreaming the opencl-examples patch, so this will not be required, thus removing the circular dependency with patch 5.
We wouldn't want to hold back this patchset until the upstreaming is completed so for not split the patches into smaller patches if required to break the circular dependency. 
> 
> 
> 
> -----Original Message-----
> From: Cooper Jr., Franklin 
> Sent: Thursday, February 26, 2015 8:57 AM
> To: Stiffler, Jacob; meta-ti at yoctoproject.org
> Subject: RE: [meta-ti] [RFC PATCH 1/6] opencl: Add common file specifying opencl sources and version.
> 
> This shouldn't be the first patch in your patchset.
> 
> You depend on files from patch 2 and 5. But those patches also depend on patch 1 for the .inc.
> 
> I guess I can kind of understand the logic but to have 6 different sources in a single inc file that is partially reused by several different recipes doesn't seem right to me...
> 
>> -----Original Message-----
>> From: meta-ti-bounces at yoctoproject.org [mailto:meta-ti- 
>> bounces at yoctoproject.org] On Behalf Of Stiffler, Jacob
>> Sent: Thursday, February 26, 2015 7:34 AM
>> To: meta-ti at yoctoproject.org
>> Subject: [meta-ti] [RFC PATCH 1/6] opencl: Add common file specifying 
>> opencl sources and version.
>> 
>> * opencl consists of multiple packages, so use this file for
>>  shared information.
>> 
>> Signed-off-by: Jacob Stiffler <j-stiffler at ti.com>
>> ---
>> recipes-ti/ocl/ocl.inc |   64
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 64 insertions(+)
>> create mode 100644 recipes-ti/ocl/ocl.inc
>> 
>> diff --git a/recipes-ti/ocl/ocl.inc b/recipes-ti/ocl/ocl.inc new file 
>> mode 100644 index 0000000..71965e2
>> --- /dev/null
>> +++ b/recipes-ti/ocl/ocl.inc
>> @@ -0,0 +1,64 @@
>> +PV = "1.1.0"
>> +
>> +LIC_FILES_CHKSUM =
>> "file://../debian/copyright;md5=d3795e71443db61e7c9677a97fa3aac4"
>> +
>> +FILESEXTRAPATHS_prepend := "${THISDIR}/ocl:"
>> +
>> +BRANCH_OCL = "master"
>> +BRANCH_OPENCL = "master"
>> +BRANCH_BUILTINS = "master"
>> +BRANCH_MONITOR = "master"
>> +BRANCH_LIBM = "master"
>> +BRANCH_EXAMPLES = "master"
>> +
>> +DESTSUFFIX_OCL = "git"
>> +DESTSUFFIX_OPENCL = "git/opencl"
>> +DESTSUFFIX_BUILTINS = "git/opencl_builtins"
>> +DESTSUFFIX_MONITOR = "git/opencl_monitor"
>> +DESTSUFFIX_LIBM = "git/open_libm"
>> +DESTSUFFIX_EXAMPLES = "git/opencl_examples"
>> +
>> +SRC_URI_BASE = "git://gitorious.design.ti.com/ocl"
>> +
>> +SRC_URI_OCL =
>> "${SRC_URI_BASE}/ocl.git;protocol=git;branch=${BRANCH_OCL};name=ocl;d
>> estsuffix=${DESTSUFFIX_OCL}"
>> +SRC_URI_OPENCL =
>> "${SRC_URI_BASE}/opencl.git;protocol=git;branch=${BRANCH_OPENCL};nam
>> e=opencl;destsuffix=${DESTSUFFIX_OPENCL}"
>> +SRC_URI_BUILTINS =
>> "${SRC_URI_BASE}/opencl_builtins.git;protocol=git;branch=${BRANCH_BUIL
>> TINS};name=opencl_builtins;destsuffix=${DESTSUFFIX_BUILTINS}"
>> +SRC_URI_MONITOR =
>> "${SRC_URI_BASE}/opencl_monitor_vayu.git;protocol=git;branch=${BRANC
>> H_MONITOR};name=opencl_monitor;destsuffix=${DESTSUFFIX_MONITOR}"
>> +SRC_URI_MONITOR_IMAGE = "http://udb0866934.am.dhcp.ti.com/mcsdk-
>> 8.x/yocto-tmp/opencl_monitor-vayu-0.12.0-
>> 1.tar.gz;name=ocl_monitor_image"
>> +SRC_URI_LIBM =
>> "${SRC_URI_BASE}/open_libm.git;protocol=git;branch=${BRANCH_LIBM};na
>> me=open_libm;destsuffix=${DESTSUFFIX_LIBM}"
>> +SRC_URI_EXAMPLES =
>> "${SRC_URI_BASE}/opencl_examples.git;protocol=git;branch=${BRANCH_EX
>> AMPLES};name=opencl_examples;destsuffix=${DESTSUFFIX_EXAMPLES}"
>> +
>> +SRCREV_ocl = "730e6c85e55770969489e4079f7b9a7071e6c8cf"
>> +SRCREV_opencl = "d00eb494d52fbe07f419bff8f21ab28c05c494b6"
>> +SRCREV_opencl_builtins = "c410a457c55973f8a5e572978c0581c42608c96c"
>> +SRCREV_opencl_monitor = "a1fbe457f3fcfc9b087c91cfe9036cf700f1b187"
>> +SRCREV_open_libm = "4f391bd2ff68a78eae3a91ba606bb86c616d3d55"
>> +SRCREV_opencl_examples =
>> "cba1bc746597a38827cab7d7e9fd9864229e298e"
>> +SRC_URI[ocl_monitor_image.md5sum] =
>> "b013b26d1809fb43893d3fbb286b0cba"
>> +SRC_URI[ocl_monitor_image.sha256sum] =
>> "5084679ab4eefa851c8bbfe95168fd82e2ff3aaea3a1cc800da04dfac1603367"
>> +
>> +OPENGL_HEADERS = " \
>> +    file://GL/gl.h \
>> +    file://GL/gl_mangle.h \
>> +    file://GL/glext.h \
>> +    file://GL/glx.h \
>> +    file://GL/glx_mangle.h \
>> +    file://GL/glxext.h \
>> +    file://GL/osmesa.h \
>> +    file://GL/wglext.h \
>> +    file://GL/wmesa.h \
>> +    file://GL/internal/dri_interface.h \ "
>> +
>> +OPENCL_PATCHES = " \
>> +"
>> +
>> +MONITOR_PATCHES = " \
>> +"
>> +
>> +EXAMPLES_PATCHES = " \
>> +    file://0001-Add-larger-sets-and-display-size-information.patch \ "
>> +
>> +SRC_URI = "${SRC_URI_OCL}"
>> +
>> --
>> 1.7.9.5
>> 
>> --
>> _______________________________________________
>> meta-ti mailing list
>> meta-ti at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-ti