[meta-ti] [morty-next][PATCH 1/2] kselftests: add libpcap-ng dependency

[Fathi Boudra]

On 17 March 2017 at 18:59, Denys Dmytriyenko <denis at denix.org> wrote:
> On Fri, Mar 17, 2017 at 04:47:59PM +0000, Khem Raj wrote:
>> On Fri, Mar 17, 2017 at 9:37 AM Fathi Boudra <fathi.boudra at linaro.org>
>> wrote:
>>
>> > libpcap-ng is required to build capabilities tests.
>> >
>> > Signed-off-by: Fathi Boudra <fathi.boudra at linaro.org>
>> > ---
>> >  recipes-kernel/kselftests/kselftests_4.9.bb | 4 +---
>> >  1 file changed, 1 insertion(+), 3 deletions(-)
>> >
>> > diff --git a/recipes-kernel/kselftests/kselftests_4.9.bb
>> > b/recipes-kernel/kselftests/kselftests_4.9.bb
>> > index a7b4ba67..dd94a65b 100644
>> > --- a/recipes-kernel/kselftests/kselftests_4.9.bb
>> > +++ b/recipes-kernel/kselftests/kselftests_4.9.bb
>> > @@ -11,7 +11,7 @@ S = "${WORKDIR}/linux-${PV}"
>> >
>> >  PACKAGE_ARCH = "${MACHINE_ARCH}"
>> >
>> > -DEPENDS = "libcap popt rsync-native"
>> > +DEPENDS = "libcap libcap-ng popt rsync-native"
>>
>>
>> Would ng replace old libcap
>
> Are you asking in general or in this particular case?
>
> kselftests-capabilities does use libcap-ng and includes cap-ng.h header file,
> as I mentioned here:
> https://lists.yoctoproject.org/pipermail/meta-ti/2017-March/009766.html
>
> Fathi's fix is indeed better, even though adding another dependency.

In this particular case, it doesn't replace libcap.
Upstream managed to use libcap-ng in capabilities test and libpcap in
bpf test...
I'm currently queuing patches for upstream.

>> >  inherit kernel-arch
>> >
>> > @@ -139,8 +139,6 @@ FILES_${PN}-x86 = "${bindir}/kselftests/x86"
>> >  FILES_${PN}-zram = "${bindir}/kselftests/zram"
>> >  FILES_${PN}-dbg += "${bindir}/kselftests/*/.debug"
>> >
>> > -ALLOW_EMPTY_${PN}-capabilities = "1"
>> > -
>> >  RDEPENDS_${PN}-cpu-hotplug += "bash"
>> >  RDEPENDS_${PN}-efivarfs += "bash"
>> >  RDEPENDS_${PN}-memory-hotplug += "bash"
>> > --
>> > 2.11.0
>> >
>> > --
>> > _______________________________________________
>> > meta-ti mailing list
>> > meta-ti at yoctoproject.org
>> > https://lists.yoctoproject.org/listinfo/meta-ti
>> >