[meta-ti] [PATCH v2 25/37] pm-lld-rtos: Adding rtos recipe for pm-lld
Denys Dmytriyenko
denys at ti.com
Tue Sep 26 11:15:30 PDT 2017
On Mon, Sep 18, 2017 at 02:03:18PM -0400, Radhakrishnan, Mahesh wrote:
> Denys,
>
> Submitted a new patch for pm-lld (attached). Responses linline.
>
> Please let me know if it looks okay now.
>
>
>
> Regards
>
> Mahesh
>
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, August 24, 2017 3:52 PM
> To: Radhakrishnan, Mahesh
> Cc: meta-ti at yoctoproject.org
> Subject: Re: [meta-ti] [PATCH v2 25/37] pm-lld-rtos: Adding rtos recipe
> for pm-lld
>
>
>
> On Tue, Jul 18, 2017 at 07:03:36PM -0400, Mahesh Radhakrishnan wrote:
>
> > Upstreaming TI RTOS low level driver for Power Management module (PM)
>
> > Signed-off-by: Mahesh Radhakrishnan <m-radhakrishnan2 at ti.com>
>
> > ---
>
> >
>
> > v2 - Added summary & merged in to a single recipe
>
> >
>
> > recipes-bsp/pm-lld/pm-lld-rtos_git.bb | 95
>
> > +++++++++++++++++++++++++++++++++++
>
> > 1 file changed, 95 insertions(+)
>
> > create mode 100644 recipes-bsp/pm-lld/pm-lld-rtos_git.bb
>
> >
>
> > diff --git a/recipes-bsp/pm-lld/pm-lld-rtos_git.bb
>
> > b/recipes-bsp/pm-lld/pm-lld-rtos_git.bb
>
> > new file mode 100644
>
> > index 0000000..c976deb
>
> > --- /dev/null
>
> > +++ b/recipes-bsp/pm-lld/pm-lld-rtos_git.bb
>
> > @@ -0,0 +1,95 @@
>
> > +SUMMARY = "TI RTOS driver for Power Management module (PM)"
>
> > +
>
> > +require recipes-ti/includes/ti-paths.inc
>
> > +
>
> > +LICENSE = "BSD-3-Clause"
>
> > +LIC_FILES_CHKSUM =
> "file://Power.h;beginline=1;endline=31;md5=527b91fdcd26cd19ac07a754f45dedbe"
>
> > +
>
> > +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k2g"
>
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> > +
>
> > +
>
> > +PM_LLD_GIT_URI = "git://git.ti.com/keystone-rtos/pm-lld.git"
>
> > +PM_LLD_GIT_PROTOCOL = "git"
>
> > +PM_LLD_GIT_BRANCH = "int_pm_am335x"
>
> > +PM_LLD_GIT_BRANCH_dra7xx-evm = "master"
>
>
>
> ^^^
>
>
>
>
>
> > +PM_LLD_GIT_DESTSUFFIX = "git/ti/drv/pm"
>
> > +
>
> > +# Below commit ID corresponds to "DEV.PM_LLD.01.04.00.01"
>
> > +PM_LLD_SRCREV = "c4908f94b3e655e6298aa9bfe9bbffbbc5d16111"
>
> > +
>
> > +# Below commit ID corresponds to "REL.PDK.TDA.01.07.00.06"
>
> > +PM_LLD_SRCREV_dra7xx-evm = "46ea13503d2991f636197edb206a9f62cea398d4"
>
>
>
> ^^^
>
>
>
> In some places here you use more generic "omap-a15" SOC family, but in
> these 2 places I highlighted, you use very specific "dra7xx-evm", which
> will exclude platforms like "dra7xx-hs-evm" as well as "am57xx-evm" and
> use "int_pm_am335x"
>
> branch for those. Please confirm you actually want to do that.
>
> Yes. I have confirmed with automotive team that we use specific versions
> for dra7xx-evm. This module is not used for dra7xx-hs-evm.
Understood, but since you specify "omap-a15" in the COMPATIBLE_MACHINE, the
recipe might get included for another platform in this family (AM5 or HS),
that is not exactly "dra7xx-evm" and fail to build, because you don't have
BRANCH and SRCREV defined properly... You might want to fix COMPATIBLE_MACHINE
to avoid any accidents in the future.
>
> > +
>
> > +BRANCH = "${PM_LLD_GIT_BRANCH}"
>
> > +SRC_URI =
> "${PM_LLD_GIT_URI};destsuffix=${PM_LLD_GIT_DESTSUFFIX};protocol=${PM_LLD_GIT_PROTOCOL};branch=${BRANCH}"
>
> > +
>
> > +#PATCHTOOL = "git"
>
> > +#SRC_URI_append = " \
>
> > +# file://.patch \
>
> > +#"
>
>
>
> Leftovers ^^^
>
> Yes. They have been removed in the latest patch.
>
>
>
>
>
> > +SRCREV = "${PM_LLD_SRCREV}"
>
> > +PV = "01.04.00.01"
>
> > +PR = "r0"
>
> > +
>
> > +S = "${WORKDIR}/${PM_LLD_GIT_DESTSUFFIX}"
>
> > +
>
> > +DEPENDS = " ti-sysbios \
>
> > + gcc-arm-none-eabi-native \
>
> > + osal-rtos \
>
> > + ca-certificates-native \
>
> > + ti-pdk-setup \
>
> > +"
>
> > +DEPENDS_append_omap-a15 = " ti-cgt-arm-native \
>
> > + ti-cgt6x-native \
>
> > + common-csl-ip-rtos \ "
>
> > +DEPENDS_append_ti33x = " starterware-rtos \ "
>
> > +DEPENDS_append_ti43x = " starterware-rtos \ "
>
> > +DEPENDS_append_k2g = " common-csl-ip-rtos \
>
> > + ti-cgt6x-native \ "
>
> > +
>
> > +# Fetch task cannot be completed until after ca-certificates-native
>
> > +populates sysroot with the SSL certificates do_fetch[depends] =
> "ca-certificates-native:do_populate_sysroot"
>
>
>
> Why? Shouldn't be a problem accessing git.ti.com over git protocol.
>
> Yes. They have been removed in the latest patch.
>
>
>
>
>
> > +export TOOLCHAIN_PATH_A15 = "${GCC_ARM_NONE_TOOLCHAIN}"
>
> > +export TOOLCHAIN_PATH_A8 = "${GCC_ARM_NONE_TOOLCHAIN}"
>
> > +export TOOLCHAIN_PATH_A9 = "${GCC_ARM_NONE_TOOLCHAIN}"
>
> > +export FPULIB_PATH =
> "${GCC_ARM_NONE_TOOLCHAIN}/lib/gcc/arm-none-eabi/4.9.3/fpu/"
>
> > +export TOOLCHAIN_PATH_M4 = "${M4_TOOLCHAIN_INSTALL_DIR}"
>
> > +export C6X_GEN_INSTALL_PATH =
> "${STAGING_DIR_NATIVE}/usr/share/ti/cgt-c6x"
>
> > +export PDK_INSTALL_PATH = "${PDK_INSTALL_DIR}/packages"
>
> > +export BIOS_INSTALL_PATH = "${SYSBIOS_INSTALL_DIR}"
>
> > +export XDC_INSTALL_PATH = "${XDC_INSTALL_DIR}"
>
>
>
> Aren't those already defined in a .inc file?
>
> In the latest patch submitted, ti-pdk.bbclass has been used and the above
> are removed.
>
>
>
> > +export PDK_PM_ROOT_PATH = "${WORKDIR}/git"
>
> > +
>
> > +# Used by DEST_ROOT to redirect binary and obj files away from
>
> > +sysroot PDK tree OBJ_DIR = "${WORKDIR}/git/ti/binary"
>
> > +
>
> > +do_compile() {
>
> > + make clean lib xdc_meta doxygen LIMIT_SOCS="${TI_PDK_LIMIT_SOCS}"
>
> > +LIMIT_BOARDS="${TI_PDK_LIMIT_BOARDS}" DEST_ROOT=${OBJ_DIR}
>
>
>
> BTW, doxygen is not available in meta-ti nor in the only other dependent
> layer which is oe-core.
>
> The doxygen target is no longer built with the latest patch.
>
>
>
> > + # Remove unnecessary files from packaging
>
> > + rm -rf patches/
>
> > +
>
> > + # Cleanup docs
>
> > + rm -rf docs/ReleaseNotes_PM_LLD.doc
>
> > + rm -rf internal/
>
> > +
>
> > + #archive
>
> > + tar -cf pm_lld.tar --exclude='*.tar' ./*
>
> > +}
>
> > +
>
> > +do_install() {
>
> > + install -d ${D}${PDK_INSTALL_DIR_RECIPE}/packages/ti/drv/pm
>
> > + find -name "*.tar" -exec tar xf {} --no-same-owner -C
> ${D}${PDK_INSTALL_DIR_RECIPE}/packages/ti/drv/pm \;
>
>
>
> Is it necessary to tar-up everything at the end of do_compile and then
> un-tar
>
> in do_install?
>
>
>
> The latest patch uses ti-pdk.bbclass and the do_Compile has been appended
> by generating a tar file which the do_install of ti-pdk.bbclass will
> untar.
>
> > +}
>
> > +
>
> > +FILES_${PN} += "${PDK_INSTALL_DIR_RECIPE}/packages"
>
> > +
>
> > +INSANE_SKIP_${PN} = "arch staticdev"
>
> > --
>
> > 1.9.1
>
> >
>
> > --
>
> > _______________________________________________
>
> > meta-ti mailing list
>
> > meta-ti at yoctoproject.org
>
> > https://lists.yoctoproject.org/listinfo/meta-ti
Received: from DFLE103.ent.ti.com (10.64.6.24) by DLEE70.ent.ti.com
(157.170.170.113) with Microsoft SMTP Server (TLS) id 14.3.294.0; Mon, 18 Sep
2017 12:54:32 -0500
Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE103.ent.ti.com
(10.64.6.24) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Mon, 18
Sep 2017 12:54:32 -0500
Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE108.ent.ti.com
(10.64.6.29) with Microsoft SMTP Server (version=TLS1_0,
cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport;
Mon, 18 Sep 2017 12:54:32 -0500
Received: from uda0875154a.am.dhcp.ti.com (ileax41-snat.itg.ti.com
[10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id
v8IHsWeb012844; Mon, 18 Sep 2017 12:54:32 -0500
From: "Radhakrishnan, Mahesh" <m-radhakrishnan2 at ti.com>
To: "meta-ti at yoctoproject.org" <meta-ti at yoctoproject.org>
CC: "Radhakrishnan, Mahesh" <m-radhakrishnan2 at ti.com>
Subject: [PATCH v4] pm-lld-rtos: Adding rtos recipe for pm-lld
Thread-Topic: [PATCH v4] pm-lld-rtos: Adding rtos recipe for pm-lld
Thread-Index: AQHTMKcuRYaJYc9W/UitrntDyLPAnw==
Date: Mon, 18 Sep 2017 13:54:28 -0400
Message-ID: <1505757268-4687-1-git-send-email-m-radhakrishnan2 at ti.com>
Content-Language: en-US
X-MS-Exchange-Organization-AuthMechanism: 10
X-MS-Exchange-Organization-AuthSource: DFLE108.ent.ti.com
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
>
> TI RTOS low level driver for Power Management module (PM)
> Signed-off-by: Mahesh Radhakrishnan <m-radhakrishnan2 at ti.com>
> ---
>
> v4 - Modified to use ti-pdk.bbclass and addressed review comments
> v3 - Removed the intermediate tar-untar for install
> v2 - Added summary & merged in to a single recipe
>
>
> recipes-bsp/pm-lld/pm-lld-rtos_git.bb | 56 +++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 recipes-bsp/pm-lld/pm-lld-rtos_git.bb
>
> diff --git a/recipes-bsp/pm-lld/pm-lld-rtos_git.bb b/recipes-bsp/pm-lld/pm-lld-rtos_git.bb
> new file mode 100644
> index 0000000..6fedc80
> --- /dev/null
> +++ b/recipes-bsp/pm-lld/pm-lld-rtos_git.bb
> @@ -0,0 +1,56 @@
> +SUMMARY = "TI RTOS driver for Power Management module (PM)"
> +
> +require recipes-ti/includes/ti-paths.inc
> +inherit ti-pdk
> +
> +LICENSE = "BSD-3-Clause"
> +LIC_FILES_CHKSUM = "file://Power.h;beginline=1;endline=31;md5=527b91fdcd26cd19ac07a754f45dedbe"
> +
> +COMPATIBLE_MACHINE = "ti33x|ti43x|omap-a15|k2g"
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> +
> +
> +PM_LLD_GIT_URI = "git://git.ti.com/keystone-rtos/pm-lld.git"
> +PM_LLD_GIT_PROTOCOL = "git"
> +PM_LLD_GIT_BRANCH = "int_pm_am335x"
> +PM_LLD_GIT_BRANCH_dra7xx-evm = "master"
> +PM_LLD_GIT_DESTSUFFIX = "git/ti/drv/pm"
> +
> +# Below commit ID corresponds to "DEV.PM_LLD.01.04.00.01"
> +PM_LLD_SRCREV = "c4908f94b3e655e6298aa9bfe9bbffbbc5d16111"
> +
> +# Below commit ID corresponds to "REL.PDK.TDA.01.07.00.06"
> +PM_LLD_SRCREV_dra7xx-evm = "46ea13503d2991f636197edb206a9f62cea398d4"
> +
> +BRANCH = "${PM_LLD_GIT_BRANCH}"
> +SRC_URI = "${PM_LLD_GIT_URI};destsuffix=${PM_LLD_GIT_DESTSUFFIX};protocol=${PM_LLD_GIT_PROTOCOL};branch=${BRANCH}"
> +
> +SRCREV = "${PM_LLD_SRCREV}"
> +PV = "01.04.00.01"
> +PR = "r0"
> +
> +S = "${WORKDIR}/${PM_LLD_GIT_DESTSUFFIX}"
> +
> +DEPENDS_append = " ti-sysbios \
> + osal-rtos \
> +"
> +DEPENDS_append_ti33x = " starterware-rtos \
> +"
> +DEPENDS_append_ti43x = " starterware-rtos \
> +"
> +export PDK_PM_ROOT_PATH = "${WORKDIR}/build"
> +export DEST_ROOT="${S}"
> +
> +# Build with make instead of XDC
> +TI_PDK_XDCMAKE = "0"
> +
> +do_compile_append() {
> + # Delete archive created by XDC release command since it does not contain all content
> + find -name "*.tar" -exec rm -f {} \;
> +
> + # Archive from build/ to capture ti/drv/pm/ in archive
> + cd ${B}
> + tar -cf pm_lld.tar --exclude='*.tar' ./*
> +}
> +
> +INSANE_SKIP_${PN} = "arch staticdev"
> --
> 1.9.1
>
More information about the meta-ti
mailing list