[meta-ti] [PATCH 4/5] beaglebone.conf: Package kernel and devicetree

[Denys Dmytriyenko]

On Wed, Oct 17, 2018 at 03:46:23PM -0400, Denys Dmytriyenko wrote:
> On Wed, Oct 17, 2018 at 12:28:52PM -0700, Khem Raj wrote:
> > Use variables from upstream u-boot, makes it easy to switch to
> > mainline u-boot from oe-core if someone wants to
> 
> Actually, those vars are not unique to upstream u-boot:
> http://arago-project.org/git/?p=meta-ti.git;a=blob;f=recipes-bsp/u-boot/u-boot-ti.inc;hb=HEAD

Sorry, had own mirror handy at the moment. :) Here's official link on YP git:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-ti/tree/recipes-bsp/u-boot/u-boot-ti.inc


> Lines #13 and #54.
> 
> 
> > Signed-off-by: Khem Raj <raj.khem at gmail.com>
> > ---
> >  conf/machine/beaglebone.conf | 12 +++++++++---
> >  1 file changed, 9 insertions(+), 3 deletions(-)
> > 
> > diff --git a/conf/machine/beaglebone.conf b/conf/machine/beaglebone.conf
> > index 25147926..9b656d01 100644
> > --- a/conf/machine/beaglebone.conf
> > +++ b/conf/machine/beaglebone.conf
> > @@ -1,6 +1,6 @@
> >  #@TYPE: Machine
> >  #@NAME: BeagleBone machine
> > -#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board 
> > +#@DESCRIPTION: Machine configuration for the http://beagleboard.org/bone board
> >  
> >  require conf/machine/include/ti33x.inc
> >  
> > @@ -17,10 +17,16 @@ SERIAL_CONSOLE = "115200 ttyS0"
> >  #UBOOT_MACHINE = "am335x_boneblack_config"
> >  
> >  WKS_FILE = "sdimage-bootpart.wks"
> > -IMAGE_BOOT_FILES = "MLO u-boot.img"
> > -IMAGE_FSTYPES += "tar.xz wic.xz"
> >  
> >  do_image_wic[depends] += "mtools-native:do_populate_sysroot dosfstools-native:do_populate_sysroot"
> > +IMAGE_BOOT_FILES ?= "u-boot.${UBOOT_SUFFIX} MLO"
> > +
> > +IMAGE_FSTYPES += "tar.xz wic.xz"
> >  
> >  # Refine the list of device targets for ti-pdk class recipes
> >  TI_PDK_LIMIT_BOARDS = "bbbAM335x"
> > +
> > +SPL_BINARY = "MLO"
> > +UBOOT_SUFFIX = "img"
> 
> Well, I see your point defining these 2 vars here, but then you don't use MLO 
> above for IMAGE_BOOT_FILES...
> 
> Also, it would make sense to start moving those vars into machine configs for 
> other machines. And make them conditional in u-boot recipe...
> 
> 
> > +IMAGE_INSTALL_append = " kernel-devicetree kernel-image-zimage"
> > -- 
> > 2.19.1
> > 
> > -- 
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti