[meta-xilinx] Bitstream/Boot.bin/etc - Providers/Virtual targets

[Michal Simek]

Hi,

On 02/20/2014 08:57 AM, Mike Looijmans wrote:
> On 02/19/2014 03:02 PM, Mike Looijmans wrote:
>> One major thing is that the SPL build fails without CONFIG_SPL_FPGA_SUPPORT
>> defined.
> 
> This one is still puzzling me.
> 
> I'd like to build it with FPGA support in the "big" u-boot, but without it in the SPL part.

What about this?

diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c
index 5738ad3..3710baf 100644
--- a/board/xilinx/zynq/board.c
+++ b/board/xilinx/zynq/board.c
@@ -59,7 +59,8 @@ int board_init(void)
         */
        writel(0x26d, 0xe0001014);

-#ifdef CONFIG_FPGA
+#if (defined(CONFIG_FPGA) && !defined(CONFIG_SPL_BUILD)) || \
+    (defined(CONFIG_SPL_FPGA_SUPPORT) && defined(CONFIG_SPL_BUILD))
        fpga_init();
        fpga_add(fpga_xilinx, &fpga);
 #endif


> The problem here is that CONFIG_FPGA_SUPPORT will cause the SPL call initialization methods that are only present when CONFIG_SPL_FPGA_SUPPORT is defined.
> 
> So currently, I can have FPGA support in BOTH or NEITHER, but not just in the big u-boot.
> 
> I'm diggin into that, as I think the initialization only needs to be called once, and that doesn't have to come from u-boot-SPL at all.

Just use what it is suitable for you.
Load fpga from spl is also correct for example when you have memory controller from PL.
U-boot is here to support all options which are useful and for this case both are useful.
If there is compilation problem just report it or fix it yourself and I will
appreciate if you will provide this patch for others too.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.yoctoproject.org/pipermail/meta-xilinx/attachments/20140220/9c4e05ec/attachment.pgp>