[meta-xilinx] [PATCH 2/2] zc702-zynq7 : Define boot files so that wic can make SD card images that boot.

[Philip Balister]

On 11/11/2014 01:55 AM, Nathan Rossi wrote:
>> -----Original Message-----
>> From: Philip Balister [mailto:philip at balister.org]
>> Sent: Tuesday, November 11, 2014 12:49 AM
>> To: Nathan Rossi
>> Cc: meta-xilinx at yoctoproject.org
>> Subject: Re: [meta-xilinx] [PATCH 2/2] zc702-zynq7 : Define boot files so
>> that wic can make SD card images that boot.
>>
>> On 11/04/2014 10:42 PM, Nathan Rossi wrote:
>>>> -----Original Message-----
>>>> From: meta-xilinx-bounces at yoctoproject.org [mailto:meta-xilinx-
>>>> bounces at yoctoproject.org] On Behalf Of Philip Balister
>>>> Sent: Saturday, November 01, 2014 12:26 AM
>>>> To: meta-xilinx at yoctoproject.org
>>>> Subject: [meta-xilinx] [PATCH 2/2] zc702-zynq7 : Define boot files so
>> that
>>>> wic can make SD card images that boot.
>>>>
>>>> Signed-off-by: Philip Balister <philip at balister.org>
>>>> ---
>>>>  conf/machine/zc702-zynq7.conf | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/conf/machine/zc702-zynq7.conf b/conf/machine/zc702-
>> zynq7.conf
>>>> index 25bd338..915c78b 100644
>>>> --- a/conf/machine/zc702-zynq7.conf
>>>> +++ b/conf/machine/zc702-zynq7.conf
>>>> @@ -24,3 +24,5 @@ MACHINE_DEVICETREE := " \
>>>>  		"
>>>>
>>>>  MACHINE_KCONFIG := "common/linux/rtc.cfg"
>>>> +
>>>> +IMAGE_BOOT_FILES = "boot.bin u-boot.img uEnv.txt uImage-zc702-
>> zynq7.dtb
>>>> uImage"
>>>
>>> Should be a ?= in case local.conf has a custom value.
>>>
>>> This looks like a good candidate to be split up a-bit and put in
>> machine-xilinx-board.inc?
>>>
>>> machine-xilinx-board.inc:
>>> IMAGE_BOOT_FILES ?= "${KERNEL_IMAGETYPE} u-boot.${UBOOT_SUFFIX}"
>>>
>>> zc702-zynq7.conf:
>>> IMAGE_BOOT_FILES += "boot.bin uEnv.txt ${KERNEL_IMAGETYPE}-
>> ${MACHINE}.dtb"
>>>
>>> So that at some point the "boot.bin" could move into the machine-xilinx-
>> board.inc definition.
>>
>> I sort of dislike hiding everything in .inc files, but will submit an
>> updated patch for this. (unless it crept in with your recent set).
> 
> What exactly do you dislike about using .inc files? Is it more of a visibility of the variables thing?

Exactly.

> 
> Minor change due to the recent changes in master, when you remake this patch, please change "uImage-zc702-zynq7.dtb" to "zc702-zynq7.dtb".
> 

Yep, I noticed this already.

Philip

>>
>> have you documented the variables that are inc files that can be
>> overridden? I know to hunt through inc files, but it seems like a guide
>> to using meta-xilinx would be very helpful for new users.
> 
> Unfortunately there is no documentation as yet, working on that though ;). It is definitely something that is needed.
> 
> Regards,
> Nathan
> 
>>
>> Philip
>>
>>>
>>> Regards,
>>> Nathan
>>>
>>>> --
>>>> 1.8.3.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> meta-xilinx mailing list
>>>> meta-xilinx at yoctoproject.org
>>>> https://lists.yoctoproject.org/listinfo/meta-xilinx
>>>
>>>
> 
>