[meta-xilinx] [PATCH] xilinx-versions: Change default main version

[Manjukumar Matha]

On Tue, Dec 22, 2015 at 01:41:01PM +1000, Nathan Rossi wrote:
> On Tue, Dec 22, 2015 at 4:19 AM, Manjukumar Harthikote Matha
> <manjukumar.harthikote-matha at xilinx.com> wrote:
> >
> >
> > On 12/20/2015 08:17 PM, Nathan Rossi wrote:
> >>
> >> On Sat, Dec 19, 2015 at 11:21 AM, Manjukumar Matha
> >> <manjukumar.harthikote-matha at xilinx.com> wrote:
> >>>
> >>> Allow CSL_VER_MAIN to be defined in local.conf.
> >>> Fetch libc version correctly from toolchain path
> >>
> >>
> >>> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha at xilinx.com>
> >>> ---
> >>
> >>
> >> What is the exact reason for this other than just allowing it to be
> >> defined in local.conf? If you are trying to support toolchains which
> >> have a version that cannot be detected by
> >> csl_get_version/csl_get_main_version, please update those functions
> >> instead so it can just auto detect the different scheme. If this is
> >> really only needed for obscure testing scenarios it would be simpler
> >> to manually override the PV of the recipe (since that is the instance
> >> where CSL_VER_MAIN is used), that can easily be done in local.conf
> >> with something like 'PV_pn-external-xilinx-toolchain = "<version>"'.
> >>
> >
> > Xilinx toolchain currently does not provide the version info (like v2015.4
> > etc). This scheme will allow to define the version of the toolchain till we
> > get a function which can report Xilinx toolchain version.
> 
> Ok, so why would this be needed over the
> PV_pn-external-xilinx-toolchain = "<version>" approach?
> 
> Also if you want to have it reporting the correct Vivado release
> version this could be implemented as a lookup table based on the code
> sourcery version or just build info that is embedded in gcc (e.g. for
> microblaze gcc -v -> 'Configured with:
> /proj/sdk/gnu/microblaze/builds/HEAD/nightly/2015_05_22' use that
> date?). And when the build info is actually embedded correctly use
> that instead.
> 

Yes we could use one of the methods you have mentioned here, however
CSL_VER_MAIN is defined in external-xilinx-toolchain.bb recipe to be
empty string. If one overrides it in local.conf, this function in
xilinx-versions will override the local.conf value. This patch will fix
that issue, otherwise we will have a recipe overriding the local.conf
value. I will leave this to your discretion, whether this is desirable. 

> >
> >> Also this change causes breakages when CSL_VER_MAIN is not set in
> >> local.conf:
> >>
> >
> > It is defined in the glibc-xlnx.bb. I didnt see this error while building
> > the master branch for core-image-minimal.
> 
> glibc-xlnx.bb does not exist in meta-xilinx. I think you are mixing
> this in with some other layers/changes which hide the issue. Try
> building with with just oe-core/meta + meta-xilinx, you will see this
> issue during the recipe parsing stage.
> 

Ooops...I had copy-paste mistake. Its in external-xilinx-toolchain.bb,
line 168. I dont get any parse error, maybe you have disabled this
recipe

Thanks
Manju
> 
> >>> _______________________________________________
> >>> meta-xilinx mailing list
> >>> meta-xilinx at yoctoproject.org
> >>> https://lists.yoctoproject.org/listinfo/meta-xilinx