[meta-xilinx] [PATCH 09/20] conf/machine: Add zybo-linux-bd-zynq7 machine support

[Jason Wu]

On 12/04/2016 6:57 PM, Nathan Rossi wrote:
> On Mon, Apr 11, 2016 at 11:23 PM, Jason Wu <jason.wu.misc at gmail.com> wrote:
>> * base on Zybo linux_bd reference design
>> * Add device tree with required nodes
>> * hdf is fetch from Digilent github
>>
>> Signed-off-by: Jason Wu <jason.wu.misc at gmail.com>
>> ---
>>   conf/machine/zybo-linux-bd-zynq7.conf              |  30 +++
>>   .../device-tree/files/zybo-linux-bd/pcw.dtsi       |  63 ++++++
>>   .../device-tree/files/zybo-linux-bd/pl.dtsi        | 213 +++++++++++++++++++++
>>   .../files/zybo-linux-bd/zybo-linux-bd.dts          | 185 ++++++++++++++++++
>>   .../hardware-definition-file/zybo-linux-bd.bb      |  22 +++
>>   5 files changed, 513 insertions(+)
>>   create mode 100644 conf/machine/zybo-linux-bd-zynq7.conf
>>   create mode 100644 recipes-bsp/device-tree/files/zybo-linux-bd/pcw.dtsi
>>   create mode 100644 recipes-bsp/device-tree/files/zybo-linux-bd/pl.dtsi
>>   create mode 100644 recipes-bsp/device-tree/files/zybo-linux-bd/zybo-linux-bd.dts
>>   create mode 100644 recipes-bsp/hardware-definition-file/zybo-linux-bd.bb
>>
>> diff --git a/conf/machine/zybo-linux-bd-zynq7.conf b/conf/machine/zybo-linux-bd-zynq7.conf
>> new file mode 100644
>> index 0000000..7c9c702
>> --- /dev/null
>> +++ b/conf/machine/zybo-linux-bd-zynq7.conf
>> @@ -0,0 +1,30 @@
>> +#@TYPE: Machine
>> +#@NAME: zybo-linux-bd-zynq7
>> +#@DESCRIPTION: Machine support for zybo-linux-bd project.
>> +#
>> +# generated base on ZYBO linux-bd project
>> +#
>> +
>> +require conf/machine/include/tune-zynq.inc
>> +require conf/machine/include/machine-xilinx-default.inc
>> +require conf/machine/include/machine-xilinx-board.inc
>> +
>> +MACHINE_FEATURES = "ext2 vfat usbhost usbgadget keyboard screen alsa sdio"
>> +SERIAL_CONSOLE = "115200 ttyPS0"
>> +
>> +MACHINE_DEVICETREE = " \
>> +               zybo-linux-bd/pcw.dtsi \
>> +               zybo-linux-bd/pl.dtsi \
>> +               zybo-linux-bd/zybo-linux-bd.dts \
>
> For consistency with other machines that output a dtb with the
> device-tree recipe, the dts/dtb should match the name of the machine.
will make this change in v2 to have zybo-linux-bd-zynq7.dts

>
>> +               "
>> +KERNEL_IMAGETYPE = "zImage"
>> +
>> +UBOOT_MACHINE = "zynq_zybo_config"
>> +SPL_BINARY = "spl/boot.bin"
>> +
>> +EXTRA_IMAGEDEPENDS += "virtual/hdf"
>
> This should be just += "virtual/bitstream". Since the u-boot recipe
> handles depending on the platform-init.
>
> Also this .conf is missing:
>
> MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "device-tree"
will add it.

>
>> +
>> +IMAGE_BOOT_FILES += "boot.bin \
>> +               ${@bb.utils.contains('IMAGE_FSTYPES', 'xilinx-fitimage', 'fit.itb', 'zybo-linux-bd.dtb', d)} \
>
> This conditional should be added with patch 13, which adds
> xilinx-fitimage to this machine. Also this should be "${MACHINE}.dtb".
will fix this in v2.

>
>> +               bitstream \
>> +               "
>
> -- snip --
>
>> diff --git a/recipes-bsp/hardware-definition-file/zybo-linux-bd.bb b/recipes-bsp/hardware-definition-file/zybo-linux-bd.bb
>> new file mode 100644
>> index 0000000..4eda840
>> --- /dev/null
>> +++ b/recipes-bsp/hardware-definition-file/zybo-linux-bd.bb
>
> This should be under 'recipes-bsp/reference-design/'.
will move it in v2.

Thanks,

Jason
>
> Regards,
> Nathan
>
>> @@ -0,0 +1,22 @@
>> +SUMMARY = "Xilinx Hardware Definition File for zybo-linux-bd"
>> +DESCRIPTION = "Contains the Reference Design Files and hardware software hand-off files."
>> +SECTION = "bsp"
>> +DEPENDS += "unzip"
>> +
>> +include hdf.inc
>> +
>> +LICENSE = "Proprietary"
>> +LIC_FILES_CHKSUM = "file://Projects/${HW_BD}/readme.txt;md5=e1cb7639bf00b6e730ff3a7f13714951"
>> +
>> +COMPATIBLE_MACHINE = "zybo-linux-bd-zynq7"
>> +
>> +HW_BD = "linux_bd"
>> +
>> +SRC_URI := "git://github.com/Digilent/ZYBO.git;protocol=https;nobranch=1"
>> +SRCREV = "63ca49fe027da49f3b0ac636bd404fd31fbbd945"
>> +
>> +PV = "+git${SRCPV}"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +HDF = "/Projects/${HW_BD}/hw_handoff/${HW_BD}_wrapper.hdf"
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> meta-xilinx mailing list
>> meta-xilinx at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-xilinx