[meta-xilinx] [PATCH] zynqmp: Make the MALI recommendation machine-specific

[Nathan Rossi]

On Fri, Aug 12, 2016 at 9:16 AM, Manjukumar Harthikote Matha
<manjukumar.harthikote-matha at xilinx.com> wrote:
>
>
> On 08/11/2016 04:34 AM, Nathan Rossi wrote:
>>
>> On Tue, Aug 9, 2016 at 7:20 AM, Manjukumar Harthikote Matha
>> <manjukumar.harthikote-matha at xilinx.com> wrote:
>>>
>>> All,
>>>
>>> <...>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> That is a definitely a better solution, then all that is needed is
>>>>>>> the two feature flags 'zynqmp-mali' (or just mali?) and 'zynqmp-venc'
>>>>>>> (or something similar). And most of the conditional selection can be
>>>>>>> done with bb.utils.contains.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> For mali maybe you could use an existing machine feature like
>>>>>> "opengl"?
>>>>>
>>>>>
>>>>>
>>>>> That would work fine too, assuming of course that the mali module does
>>>>> not provide
>>>>> any api's other than those needed for the user-space opengl support.
>>>>> But
>>>>> even then
>>>>> the contains_any can handle checking if the machine provides multiple
>>>>> features
>>>>> where the mali module is needed.
>>>>>
>>>>> Manju if you are good with using the "opengl" machine feature flag for
>>>>> this we can
>>>>> handle the video encoder naming seperately.
>>>>>
>>>> MALI user-space binaries provide gles1, gles2 and egl. For the entire
>>>> stack you would still need Mesa providing gl. Is it better if we just
>>>> use
>>>> "mali" and "vcu" ?
>>>>
>>>> Also, I have seen "opengl" being used as distro features very often.
>>>>
>>>
>>> I was thinking on using "gpu" and "vcu" as MACHINE features
>>>
>>> Let me know if this is acceptable
>>
>>
>> So I think the best option here would be to go with 'mali', here are a
>> few reasons why:
>>  * 'mali' - matches the actual block name that is provided as a
>> feature, this also does not present potential confusion with e.g.
>> 'opengl'/'gpu' which could mean something else in the case that a user
>> has custom logic that provides this functionality?
>>  * 'opengl' - since mali does not provide full opengl API support this
>> might be confusing
>>  * other layers (where something like this is done) use the name of
>> the block/IP, e.g. meta-ti uses 'sgx' for the powervr sgx
>>
>> As for 'vcu', given this is the naming in technical documents I think
>> this is acceptable.
>>
> MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS =
> "${@bb.utils.contains('MACHINE_FEATURES', 'mali', ' kernel-module-mali', '',
> d)}"
>
> We can add this to machine-xilinx-defaults.inc I guess
>

I've added this, and setup zcu102 to have the mali feature.

Regards,
Nathan