[meta-xilinx] [PATCH V3 2/3] qemu-devicetrees: Build the Xilinx QEMU device trees

[Nathan Rossi]

On Fri, Aug 12, 2016 at 9:43 AM, Alistair Francis
<alistair.francis at xilinx.com> wrote:
> On Thu, Aug 11, 2016 at 2:47 PM, Alistair Francis
> <alistair.francis at xilinx.com> wrote:
>> Signed-off-by: Alistair Francis <alistair.francis at xilinx.com>
>> ---
>>  recipes-devtools/qemu/qemu-devicetrees_2.2.5.bb | 41 +++++++++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>>  create mode 100644 recipes-devtools/qemu/qemu-devicetrees_2.2.5.bb
>>
>> diff --git a/recipes-devtools/qemu/qemu-devicetrees_2.2.5.bb b/recipes-devtools/qemu/qemu-devicetrees_2.2.5.bb
>> new file mode 100644
>> index 0000000..d06f601
>> --- /dev/null
>> +++ b/recipes-devtools/qemu/qemu-devicetrees_2.2.5.bb
>> @@ -0,0 +1,41 @@
>> +SUMMARY = "Xilinx's hardware device trees required for QEMU"
>> +HOMEPAGE = "https://github.com/xilinx/qemu-devicetrees/"
>> +LICENSE = "BSD"
>> +DEPENDS += "dtc-native"
>> +
>> +LIC_FILES_CHKSUM = "file://README;md5=0f52b512c21e3541b90ca9fa39aff8fe"

The readme file doesn't actual specify the license, you can use the
follow to get the header from the Makefile and checksum it:

LIC_FILES_CHKSUM = "file://Makefile;beginline=1;endline=27;md5=..."

>> +
>> +SRCREV = "3ebe0ecc634c25e8a79655f9465cf614dff62390"
>> +SRC_URI = "git://github.com/Xilinx/qemu-devicetrees.git;protocol=https;nobranch=1  \
>> +          "

No need to put this on 2 lines.

>> +
>> +S = "${WORKDIR}/git"
>> +
>> +FILES_${PN} += " \
>> +               LATEST/SINGLE_ARCH/zcu102-arm.dtb \
>> +               "
>> +
>> +do_compile() {
>> +       make
>> +}
>
> I don't need this.
>
>> +
>> +# Don't need to do anything
>> +do_install() {
>> +       :
>> +}
>
> I can do this instead:
> do_install[NOEXEC] = "1"

You can also remove the FILES_* value since it is not installing the dtb.

>
> Thanks,
>
> Alistair
>
>> +
>> +do_deploy() {
>> +       for DTS_FILE in ${S}/LATEST/SINGLE_ARCH/*.dtb; do
>> +               echo "any chance?"

Debug output?

>> +               if [ ! -f ${DTS_FILE} ]; then
>> +                       echo "Warning: ${DTS_FILE} is not available!"

I've been meaning to fix this up in device-tree.bb as well. Instead of
echo this should be bbwarn, e.g.:

bbwarn "${DTS_FILE} is not available!"

Regards,
Nathan

>> +                       continue
>> +               fi
>> +               DTS_NAME=`basename -s .dtb ${DTS_FILE}`
>> +               install -d ${DEPLOY_DIR_IMAGE}
>> +               install -d ${DEPLOY_DIR_IMAGE}/qemu-hw-devicetrees
>> +               install -m 0644 ${S}/LATEST/SINGLE_ARCH/${DTS_NAME}.dtb ${DEPLOY_DIR_IMAGE}/qemu-hw-devicetrees/${DTS_NAME}.dtb
>> +       done
>> +}
>> +
>> +addtask deploy after do_install
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> meta-xilinx mailing list
>> meta-xilinx at yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-xilinx