[meta-xilinx] [PATCH v1] qemuzynmp: Add the qemuzynqmp machine

[Nathan Rossi]

On Tue, Jun 14, 2016 at 2:25 AM, Alistair Francis
<alistair.francis at xilinx.com> wrote:
> On Tue, May 17, 2016 at 9:40 AM, Alistair Francis
> <alistair.francis at xilinx.com> wrote:
>> On Tue, May 17, 2016 at 6:27 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
>>> On Tue, May 17, 2016 at 8:20 AM, Alistair Francis
>>> <alistair.francis at xilinx.com> wrote:
>>>> On Mon, May 16, 2016 at 9:39 AM, Alistair Francis
>>>> <alistair.francis at xilinx.com> wrote:
>>>>> On Sun, May 15, 2016 at 10:10 AM, Peter Crosthwaite
>>>>> <crosthwaitepeter at gmail.com> wrote:
>>>>>> On Sun, May 15, 2016 at 1:17 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
>>>>>>> On Sat, May 14, 2016 at 2:54 AM, Alistair Francis
>>>>>>> <alistair.francis at xilinx.com> wrote:
>>>>>>>> On Fri, May 13, 2016 at 2:35 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
>>>>>>>>> On Fri, May 13, 2016 at 6:11 AM, Alistair Francis
>>>>>>>>> <alistair.francis at xilinx.com> wrote:
>>>>>>>>>> Add the qemuzynqmp machine based on the physical ZCU02 revB board.
>>>>>>>>>
>>>>>>>>> Hi Alistair,
>>>>>>>>>
>>>>>>>>> So I am a little confused, is this machine supposed to emulate the
>>>>>>>>> ep108 (the args to QEMU appear to be for the ep108) or the zcu102? or
>>>>>>>>> are both able to be emulated?
>>>>>>>>
>>>>>>>> Hey Nathan,
>>>>>>>>
>>>>>>>> This machine is supposed to be emulating the ZCU102.
>>>>>>>>
>>>>>>>> At the moment we only have the EP108 in upstream QEMU. It isn't worth
>>>>>>>> adding a ZCU102 model upstream yet as at the moment we don't have
>>>>>>>> enough modeled upstream to notice any differences between the boards.
>>>>>>>
>>>>>>> Ah ok, so in the future QEMU will have models for both the EP108 and
>>>>>>> the ZCU102 boards. In that case I don't actually see a need for a
>>>>>>> 'qemuzynqmp' machine, since the ep108-zynqmp already provides the
>>>>>>> setup for QEMU. The same can be done for the zcu102-zynqmp board, this
>>>>>>> would also make it easier to maintain consistency (aka changes only
>>>>>>> need to be made to the zcu102-zynqmp machine).
>>>>>>>
>>>>>>
>>>>>> +1, qemuzynq as well as the "zynq" machine model in upstream QEMU are
>>>>>> legacy convention that we should replace with concrete boards going
>>>>>> forward.
>>>>>
>>>>> Ok, I'll look into adding a ZCU102 machine similar to what we do for the EP108.
>>>>
>>>> How can I run the EP108 on QEMU? I can't find how I can start QEMU with Yocto.
>>>
>>> There is no runqemu support though the ep108 machine is setup to build
>>> qemu-native for use. But there was a guide created back when first
>>> adding zynqmp, essentially it is manually running QEMU with the
>>> correct args. http://www.wiki.xilinx.com/Yocto+for+zynqmp
>>
>> Ok, but I'm looking for adding runqemu support to Yocto. The way that
>> everyone else seems to do it is by architecture and not by board so I
>> think that is my only option.
>>
>> Do you have a better idea of adding runqemu support?
>
> This has been accepted in poky master branch with this commit:
> commit ff3bc6c61f5946aa5e91a77442d828ec1a03387d
> Author: Alistair Francis <alistair.francis at xilinx.com>
> Date:   Thu May 12 14:37:39 2016 -0700
>
>     runqemu: Add suport for qemuzynqmp
>
>     (From OE-Core rev: d2a7c1db9bff6ae3844e3d017e94f29d1501bf57)
>
>     Signed-off-by: Alistair Francis <alistair.francis at xilinx.com>
>     Signed-off-by: Ross Burton <ross.burton at intel.com>
>     Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>
>
> Can we work on merging this in meta-xilinx now?

I will accept the addition of this machine given that it will only
exist for the purposes of runqemu, and it will be removed in the
future once runqemu is able to handle using the actual machine
targets. But there should be no specific configuration/overrides for
this machine, it should be equivalent to the target QEMU model, in
this case ep108-zynqmp.

But between this patch, your patch to runqemu and that with qemu 2.6.0
zynqmp does not boot correctly. I don't see a point in merging this
addition until all parts are working as expected. This means that
runqemu should be setup to direct boot the kernel, as this works fine
with qemu 2.5 (and should also work fine with 2.6 once the cpu bring
up issue is resolved).

---

With regards to this patch, please change it so that it is just
including the ep108 machine. Something like the following in
qemuzynqmp.conf.

MACHINEOVERRIDES =. "ep108-zynqmp:"
require conf/machine/ep108-zynqmp.conf

As for setting the "QEMU_DTB", this can be set in the ep108 conf. I
would also suggest using the kernel_devicetree/imagetype to set it.

QEMU_DTB = "${KERNEL_IMAGETYPE}-${@os.path.splitext(os.path.basename(d.getVar("KERNEL_DEVICETREE",
True)))[0]}"

As for the kernel changes, that kernel config is broken for QEMU.

Regards,
Nathan