[meta-xilinx] [PATCH] mali: fix a typo in using stringify macro

[Khan, Yasir]

Hello,

Thanks for your feedback. I've sent another patch which removes these trace macros as suggested. Kindly review that.

Thanks,
Yasir
________________________________________
From: Hyun Kwon <hyun.kwon at xilinx.com>
Sent: Wednesday, November 2, 2016 10:27 PM
To: Khan, Yasir; meta-xilinx at lists.yoctoproject.org
Cc: Manjukumar Harthikote Matha
Subject: RE: [meta-xilinx] [PATCH] mali: fix a typo in using stringify macro

Hi Yasir,

Thanks for the patch.

> -----Original Message-----
> From: meta-xilinx-bounces at yoctoproject.org [mailto:meta-xilinx-
> bounces at yoctoproject.org] On Behalf Of Yasir Khan
> Sent: Monday, October 31, 2016 7:44 AM
> To: meta-xilinx at lists.yoctoproject.org
> Subject: [meta-xilinx] [PATCH] mali: fix a typo in using stringify macro
>
> From: Yasir-Khan <yasir_khan at mentor.com>
>
> When mali kernel module is built with tracing enabled, it throws compilation
> error due to a typo in stringify macro.
>
> Signed-off-by: Yasir-Khan <yasir_khan at mentor.com>
> ---
>  recipes-graphics/mali/kernel-module-mali.bb        |  1 +
>  ...i_linux_trace-fix-typo-in-stringify-macro.patch | 29
> ++++++++++++++++++++++
>  2 files changed, 30 insertions(+)
>  create mode 100644 recipes-graphics/mali/kernel-module-mali/0001-
> mali_linux_trace-fix-typo-in-stringify-macro.patch
>
> diff --git a/recipes-graphics/mali/kernel-module-mali.bb b/recipes-
> graphics/mali/kernel-module-mali.bb
> index c809243..128973d 100644
> --- a/recipes-graphics/mali/kernel-module-mali.bb
> +++ b/recipes-graphics/mali/kernel-module-mali.bb
> @@ -11,6 +11,7 @@ PV = "r5p1-01rel0"
>  SRC_URI = " \
>       http://malideveloper.arm.com/downloads/drivers/DX910/${PV}/DX910-
> SW-99002-${PV}.tgz \
>       file://Makefile.patch \
> +     file://0001-mali_linux_trace-fix-typo-in-stringify-macro.patch \
>       "
>  SRC_URI[md5sum] = "9c85c113e4d41ae992e45ba27287d1ab"
>  SRC_URI[sha256sum] =
> "86209c99c36a7622402b016b6f764c212b738ccdec9cdc6d6f16758c013957a0"
> diff --git a/recipes-graphics/mali/kernel-module-mali/0001-mali_linux_trace-fix-
> typo-in-stringify-macro.patch b/recipes-graphics/mali/kernel-module-
> mali/0001-mali_linux_trace-fix-typo-in-stringify-macro.patch
> new file mode 100644
> index 0000000..5657442
> --- /dev/null
> +++ b/recipes-graphics/mali/kernel-module-mali/0001-mali_linux_trace-fix-
> typo-in-stringify-macro.patch
> @@ -0,0 +1,29 @@
> +From 69e3a37715600761358c58d71a777d292cb429dd Mon Sep 17 00:00:00
> 2001
> +From: Yasir-Khan <yasir_khan at mentor.com>
> +Date: Mon, 31 Oct 2016 16:45:46 +0500
> +Subject: [PATCH] mali_linux_trace: fix typo in stringify macro
> +
> +When mali kernel module is built with tracing enabled, we get
> +compilation error due to a typo in stringify macro.
> +
> +Signed-off-by: Yasir-Khan <yasir_khan at mentor.com>
> +---
> + driver/src/devicedrv/mali/linux/mali_linux_trace.h | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/driver/src/devicedrv/mali/linux/mali_linux_trace.h
> b/driver/src/devicedrv/mali/linux/mali_linux_trace.h
> +index c6cd2bf..7c27b92 100644
> +--- a/linux/mali_linux_trace.h
> ++++ b/linux/mali_linux_trace.h
> +@@ -18,7 +18,7 @@
> +
> + #undef  TRACE_SYSTEM
> + #define TRACE_SYSTEM mali
> +-#define TRACE_SYSTEM_STRING __stringfy(TRACE_SYSTEM)
> ++#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)

Wouldn't it make more sense to remove this macro from MALI driver? In recent Linux kernel, all TRACE_SYSTEM_STRING have been removed: ex, https://patchwork.kernel.org/patch/6150651/

Similar patch has been merged in Xilinx Linux tree: https://github.com/Xilinx/linux-xlnx/commit/dadb5e41f28f9619debc9aae4ae543aa1dcd5be8

Thanks,
-hyun



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.