[meta-xilinx] [PATCH 16/29] qemumicroblaze-s3adsp1800: Add runqemu support

[Alistair Francis]

On Thu, Sep 29, 2016 at 7:48 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
> On Thu, Sep 29, 2016 at 7:41 AM, Alistair Francis <alistair23 at gmail.com> wrote:
>> On Wed, Sep 28, 2016 at 8:15 AM, Nathan Rossi <nathan at nathanrossi.com> wrote:
>>> Add runqemu support using the 'petalogix-s3adsp1800' QEMU machine. Based
>>> on the qemumicroblaze runqemu setup.
>>>
>>> Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
>>> ---
>>>  conf/machine/qemumicroblaze-s3adsp1800.conf | 11 +++++++++++
>>>  1 file changed, 11 insertions(+)
>>>
>>> diff --git a/conf/machine/qemumicroblaze-s3adsp1800.conf b/conf/machine/qemumicroblaze-s3adsp1800.conf
>>> index 330500c8a3..65a8500314 100644
>>> --- a/conf/machine/qemumicroblaze-s3adsp1800.conf
>>> +++ b/conf/machine/qemumicroblaze-s3adsp1800.conf
>>> @@ -16,3 +16,14 @@ SERIAL_CONSOLE = "115200 ttyUL0"
>>>
>>>  MACHINE_ESSENTIAL_EXTRA_RDEPENDS_remove = "device-tree"
>>>
>>> +# For runqemu
>>> +IMAGE_CLASSES += "qemuboot"
>>> +QB_SYSTEM_NAME = "qemu-system-microblaze"
>>> +QB_MEM = "-m 256"
>>> +QB_MACHINE = "-machine petalogix-s3adsp1800"
>>> +QB_OPT_APPEND = "-nographic -serial mon:stdio"
>>> +QB_DEFAULT_FSTYPE = "cpio"
>>> +QB_KERNEL_CMDLINE_APPEND = "console=ttyUL0 earlyprintk"
>>> +QB_TAP_OPT = "-netdev tap,id=net0,ifname=@TAP@,script=no,downscript=no -net nic,netdev=net0,macaddr=@MAC@"
>>> +QB_SLIRP_OPT = "-netdev user,id=net0 -net nic,netdev=net0"
>>
>> I didn't realise this machine existed!
>>
>> While we are having all this churn is there any possibility of
>> removing the 'qemumicroblaze' part of the names, and just have the
>> machines be named after the QEMU machine name?
>> Then if we remove the qemuzynq machine there will be no qemu* machines left.
>
> I'm not sure on renaming them. There are a couple of issues with
> removing the qemu* naming.
>
> * (qemuzynq) Not a real board, what would you name it?
> xilinx-zynq-a9-zynq7, just seems a bit odd :P.

Hmm.. That is a good point.

> * (qemuzynq) Maybe time to make the QEMU model match a real board (zc702?)?

Also another good point, although not in the plan at the moment.

> * (qemumicroblaze*) Whilst real boards, there are no bitstreams or
> default designs as these QEMU models were based on some now very old
> BSPs that PetaLinux shipped
> * Also giving them names like "s3adsp1800-microblazeeb" has the
> reverse implication that there is physical board support aka U-Boot,
> bitstream, etc.
> * Maybe using "s3adsp1800-qemu-microblazeeb" could work, but its a
> little long?... I was actually planning on renaming the s3adsp1800 to
> qemumicroblazeeb now that it has runqemu support

I think all of these are good points, but it is also confusing that
two out of three platforms have 'qemu' machines while ZynqMP doesn't.

For MicroBlaze I think we should move away from qemumicroblaze to
something more along the lines of ml605-microblaze-qemu (or something
like that). That way at least all of the machine names match between
QEMU and Yocto.

For Zynq-7000 this is harder. We don't really want to commit to
maintaining a ZC702 model in mainline QEMU (although we probably
should).

Can we add clear documentation somewhere explaining what the boards
support and that for ZynqMP QEMU is supported as well as HW? Even
though it's not in the name.

Thanks,

Alistair

>
> However I am open to suggestions, feel free to throw ideas out :).
>
> Regards,
> Nathan
>
>>
>> Reviewed-by: Alistair Francis <alistair.francis at xilinx.com>
>>
>> Thanks,
>>
>> Alistair
>>
>>> +
>>> --
>>> 2.9.3
>>> --
>>> _______________________________________________
>>> meta-xilinx mailing list
>>> meta-xilinx at yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/meta-xilinx