[meta-xilinx] [PATCH v2 2/3] device-tree.bb: Provide override device tree directory

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Nathan Rossi [mailto:nathan at nathanrossi.com]
> Sent: Saturday, December 02, 2017 11:17 PM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: meta-xilinx at lists.yoctoproject.org
> Subject: Re: [meta-xilinx] [PATCH v2 2/3] device-tree.bb: Provide override device
> tree directory
> 
> On 1 December 2017 at 09:27, Manjukumar Matha <manjukumar.harthikote-
> matha at xilinx.com> wrote:
> > Provide a way to override device tree work directory and include file
> > directory, this might be particalarly helpful while using this recipes
> > in other layers, for example in meta-xilinx-tools to override workdir
> > and point it to dtg based build directory
> >
> > Signed-off-by: Manjukumar Matha
> > <manjukumar.harthikote-matha at xilinx.com>
> > ---
> >  recipes-bsp/device-tree/device-tree.bb | 15 +++++++++------
> >  1 file changed, 9 insertions(+), 6 deletions(-)
> >
> > diff --git a/recipes-bsp/device-tree/device-tree.bb
> > b/recipes-bsp/device-tree/device-tree.bb
> > index 27e1017..ee22c6d 100644
> > --- a/recipes-bsp/device-tree/device-tree.bb
> > +++ b/recipes-bsp/device-tree/device-tree.bb
> > @@ -34,14 +34,17 @@ KERNEL_DTS_INCLUDE_append_zynqmp = " \
> >                 ${STAGING_KERNEL_DIR}/arch/${ARCH}/boot/dts/xilinx \
> >                 "
> >
> > +DTS_INCLUDE ?= "${S} ${KERNEL_DTS_INCLUDE}"
> 
> This should include ${DTS_FILES_PATH} instead of ${S}? In order to match the
> change from the v1 of this patch.
> 
> > +DTS_FILES_PATH ?= "${S}"
> 
> I like this name much better than the previous.
> 
> But otherwise looks good, and same for the other two patches in this series.
> 
> Reviewed-by: Nathan Rossi <nathan at nathanrossi.com>
> 

Thanks, applied

Thanks,
Manju

> Regards,
> Nathan
> 
> > +
> >  DEVICETREE_FLAGS ?= " \
> > -               -R 8 -p 0x3000 -b 0 -i ${S} \
> > -               ${@' '.join(['-i %s' % i for i in d.getVar('KERNEL_DTS_INCLUDE',
> True).split()])} \
> > -               "
> > +               -R 8 -p ${DT_PADDING_SIZE} -b 0 \
> > +               ${@' '.join(['-i %s' % i for i in d.getVar('DTS_INCLUDE', True).split()])} \
> > +               "
> >  DEVICETREE_OFLAGS ?= "-@ -H epapr"
> >  DEVICETREE_PP_FLAGS ?= " \
> > -               -nostdinc -Ulinux -x assembler-with-cpp -I${S} \
> > -               ${@' '.join(['-I%s' % i for i in d.getVar('KERNEL_DTS_INCLUDE',
> True).split()])} \
> > +               -nostdinc -Ulinux -x assembler-with-cpp \
> > +               ${@' '.join(['-I%s' % i for i in
> > + d.getVar('DTS_INCLUDE', True).split()])} \
> >                 "
> >
> >  python () {
> > @@ -51,7 +54,7 @@ python () {
> >  }
> >
> >  do_compile() {
> > -       for DTS_FILE in ${S}/*.dts; do
> > +       for DTS_FILE in ${DTS_FILES_PATH}/*.dts; do
> >                 DTS_NAME=`basename -s .dts ${DTS_FILE}`
> >                 ${BUILD_CPP} ${DEVICETREE_PP_FLAGS} -o `basename
> > ${DTS_FILE}`.pp ${DTS_FILE}
> >
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > meta-xilinx mailing list
> > meta-xilinx at yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-xilinx