[meta-xilinx] [PATCH] qemu-xilinx: Add support for building extensible SDK

[Nathan Rossi]

On 31 January 2017 at 11:21, Alistair Francis
<alistair.francis at xilinx.com> wrote:
> This patch allows the user to build an extensible SDK including the
> Xilinx fork of QEMU.
>
> Signed-off-by: Alistair Francis <alistair.francis at xilinx.com>
> ---
>  recipes-devtools/qemu/qemu-xilinx_2017.1.bb | 28 +++++++++++++++++-----------
>  1 file changed, 17 insertions(+), 11 deletions(-)
>
> diff --git a/recipes-devtools/qemu/qemu-xilinx_2017.1.bb b/recipes-devtools/qemu/qemu-xilinx_2017.1.bb
> index ee6b1e9..3239f59 100644
> --- a/recipes-devtools/qemu/qemu-xilinx_2017.1.bb
> +++ b/recipes-devtools/qemu/qemu-xilinx_2017.1.bb
> @@ -22,23 +22,29 @@ KVMENABLE = "--disable-kvm"
>  # Strip all appends (needed because qemu.inc adds patches using overrides)
>  SRC_URI[_append] = ""
>
> +DISABLE_STATIC_pn-qemu-xilinx = ""
>  DISABLE_STATIC_pn-qemu-xilinx-native = ""
> -DISABLE_STATIC_pn-nativesdk-qemu-xilinx-native = ""
> +DISABLE_STATIC_pn-nativesdk-qemu-xilinx = ""
>
>  # append a suffix dir, to allow multiple versions of QEMU to be installed
> -datadir_append = "/qemu-xilinx"
> -bindir_append = "/qemu-xilinx"
> -libexecdir_append = "/qemu-xilinx"
> -
> -# ensure configure is passed the modified dirs
> -EXTRA_OECONF += " \
> -               --bindir=${bindir} \
> -               --datadir=${datadir} \
> -               --mandir=${mandir} \
> -               --docdir=${docdir} \
> +EXTRA_OECONF_append = " \
> +               --bindir=${bindir}/qemu-xilinx \
> +               --libexecdir=${libexecdir}/qemu-xilinx \
> +               --datadir=${datadir}/qemu-xilinx \
>                 "
>
> +do_compile_ptest() {
> +       :
> +}
> +
> +do_install_ptest() {
> +       :
> +}

Just setting PTEST_ENABLED = "" somewhere after the qemu.inc should be
enough to disable all ptest functionality. Since there are other parts
of ptest still doing things even with these tasks being empty (e.g.
Packages, do_configure_ptest, depending on the ptest-runner, etc.).

> +
>  do_install() {
>         export STRIP="true"
>         autotools_do_install
> +
> +    # Prevent QA warnings about installed ${localstatedir}/run
> +    if [ -d ${D}${localstatedir}/run ]; then rmdir ${D}${localstatedir}/run; fi

When you do a v2, please fix up the indenting here for consistency.

Thanks,
Nathan