[meta-xilinx] [PATCH 2/2] xilinx-bootbin.bbclass: fix task dependencies when using wic

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Jean-Francois Dagenais [mailto:jeff.dagenais at gmail.com]
> Sent: Sunday, June 04, 2017 6:28 PM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>;
> michal.simek at xilinx.com; meta-xilinx at yoctoproject.org
> Cc: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> Subject: [PATCH 2/2] xilinx-bootbin.bbclass: fix task dependencies when using wic
>
> Image recipes create rootfs' which aren't generally included in a
> boot.bin. So there is no reason for the bif generation to wait for
> do_image_complete to be done. The bif creation is already bound to it's
> own task dependencies using the depends var flags populated by the
> get_bootbin_depends return value.
>
> Inserting the boot.bin generation between do_image_complete and do_build
> makes it impossible for do_image_wic to find the boot.bin in the
> DEPLOY_DIR. This is because do_image_wic (and _wicenv) is performed
> before image do_build.
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> ---
>  classes/xilinx-bootbin.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/classes/xilinx-bootbin.bbclass b/classes/xilinx-bootbin.bbclass
> index db2235b..31a38a6 100644
> --- a/classes/xilinx-bootbin.bbclass
> +++ b/classes/xilinx-bootbin.bbclass
> @@ -54,7 +54,7 @@ python do_create_bif() {
>      biffd.write("}")
>      biffd.close()
>  }
> -addtask do_create_bif after do_image_complete before do_xilinx_bootbin
> +addtask do_create_bif before do_xilinx_bootbin
>
>  do_create_bif[vardeps] += "BIF_PARTITION_ATTR BIF_PARTITION_IMAGE
> BIF_COMMON_ATTR"
>  do_create_bif[depends] += "${@get_bootbin_depends(d)}"
> @@ -80,4 +80,4 @@ do_xilinx_bootbin () {
>      fi
>      install -m 0644 BOOT.bin  ${DEPLOY_DIR_IMAGE}/BOOT.bin
>  }
> -addtask do_xilinx_bootbin after do_image_complete before do_build
> +addtask do_xilinx_bootbin before do_image

ACK and applied

Thanks
Manju

> --
> 2.1.4



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.