[meta-xilinx] tools: app.tcl exits 0 regardless of build failure

[Mike Looijmans]

On 02-06-17 21:21, Jean-Francois Dagenais wrote:
> Hi guys,
> 
> Take a look at this:
> https://github.com/Xilinx/meta-xilinx-tools/blob/master/scripts/app.tcl#L131
> 
> There's an "exit 0" regardless of the build success or failure! WOW.
> 
> I stubbled on this by intentionally putting an error in the workdir of
> pmu-firmware's build dir. The log.do_compile does show the error and make
> reports it, yet my yocto build succeeds!

This is the case for most of Xilinx's tools too, they will return a "0" 
exit status even if the bitstream generation (or whatever) failed, also 
when the tcl script errors out, the tool still returns 0.

As a workaround, I always remove any existing target files before 
starting, and then add a "test -e ..." to the do_compile to make it fail 
when the program failed to produce any output.


-- 
Mike Looijmans


Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans at topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail



Join our presentation at Electronics & Applications 2017:
FPGA for real-time data processing, subject “Hardware platform for industrial ultrasound steel plate Inspection” Topic Embedded Systems - Herman Kuster, 1st June 10 AM

Visit http://eabeurs.nl/author/612884/ for more information