[meta-xilinx] [PATCH] xsctapp: workaround xsct exit code convention violation

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Jean-Francois Dagenais [mailto:jeff.dagenais at gmail.com]
> Sent: Monday, June 05, 2017 6:03 AM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>;
> michal.simek at xilinx.com; meta-xilinx at yoctoproject.org
> Cc: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> Subject: [PATCH] xsctapp: workaround xsct exit code convention violation
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> ---
>  classes/xsctapp.bbclass | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/classes/xsctapp.bbclass b/classes/xsctapp.bbclass index 5fecfe6..9e0d0ac
> 100644
> --- a/classes/xsctapp.bbclass
> +++ b/classes/xsctapp.bbclass
> @@ -30,6 +30,15 @@ do_install() {
>       :
>  }
>
> +# This is a temporary patch to circumvent xsct tools not respecting exit code
> convention:
> +do_compile_prepend() {
> +    rm -f ${XSCTH_WS}/${XSCTH_PROJ}/${XSCTH_EXECUTABLE}
> +}
The clean should be handling removing of existing elf files.
https://github.com/Xilinx/meta-xilinx-tools/blob/master/scripts/app.tcl#L5


> +# The second part of this patch is to check if the exe came out of the process:
> +do_compile_append() {
> +    test -e ${XSCTH_WS}/${XSCTH_PROJ}/${XSCTH_EXECUTABLE}

I added similar test in do_compile to catch the error.
I will send out the patch soon as RFC

Thanks
Manju

> +}
> +
>  do_deploy() {
>      install -d ${DEPLOYDIR}
>      install -m 0644 ${XSCTH_WS}/${XSCTH_PROJ}/${XSCTH_EXECUTABLE}
> ${DEPLOYDIR}/${XSCTH_BASE_NAME}.elf
> --
> 2.1.4



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.