[meta-xilinx] [PATCH 1/2] xsct-tc.bbclass: inherit xsctbase to get default XILINX_VER_MAIN value

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Jean-Francois Dagenais [mailto:jeff.dagenais at gmail.com]
> Sent: Sunday, June 04, 2017 6:28 PM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>;
> michal.simek at xilinx.com; meta-xilinx at yoctoproject.org
> Cc: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> Subject: [PATCH 1/2] xsct-tc.bbclass: inherit xsctbase to get default
> XILINX_VER_MAIN value
>
> We shouldn't count on local.conf to define a value for XILINX_VER_MAIN.
> The use case for local.conf is to handle "local" definitions for the build. Xilinx SDK
> version pinning is normally carefully chosen and kept under source control, i.e. in a
> layer repo.
>
> The default value for this variable found in xsctbase.bbclass is as good as any place.
>
> Since xsct-tc.bbclass references XILINX_VER_MAIN, it should explicitely consider the
> file which defines a convenient default value for it.
>
> This fixes the "bootgen: command not found" error from xilinx-bootbin.bbclass
> when XILINX_VER_MAIN is not defined in local.conf (or some other global conf file
> such as poky.conf).
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais at gmail.com>
> ---
>  classes/xsct-tc.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/classes/xsct-tc.bbclass b/classes/xsct-tc.bbclass index 937fbd2..880a9da
> 100644
> --- a/classes/xsct-tc.bbclass
> +++ b/classes/xsct-tc.bbclass
> @@ -1,3 +1,5 @@
> +inherit xsctbase
> +
Hi,

We kind of enforced the version check to local.conf to make sure that we don't run into issues of using 2017.1 codebase with older version of toolset (like 2016.3 xsct).

I think it might be better to move the definition of the XILINX_VER_MAIN to xsct-tc instead of xsctbase.bbclass.

Thanks
Manju

>  XSCT_PATH_ADD = "${XILINX_SDK_TOOLCHAIN}/bin:"
>  PATH =. "${XSCT_PATH_ADD}"
>
> --
> 2.1.4



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.