[meta-xilinx] [PATCH] machine-xilinx-default.inc: Add default tune for multilib lib32 builds

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: Nathan Rossi [mailto:nathan at nathanrossi.com]
> Sent: Tuesday, May 30, 2017 3:54 AM
> To: Manjukumar Harthikote Matha <MANJUKUM at xilinx.com>
> Cc: meta-xilinx at lists.yoctoproject.org
> Subject: Re: [meta-xilinx] [PATCH] machine-xilinx-default.inc: Add default tune for
> multilib lib32 builds
>
> On 27 May 2017 at 08:18, Manjukumar Matha <manjukumar.harthikote-
> matha at xilinx.com> wrote:
> > On ZU+ machines, we set the default tune for the lib32 multilib
> > configuration.This allows users to select multilib by simply requiring
> > conf/multilib.conf in their build setups.
> >
> > Signed-off-by: Cyril Chemparathy <cyril.chemparathy at xilinx.com>
> > Signed-off-by: Manjukumar Matha
> > <manjukumar.harthikote-matha at xilinx.com>
> > ---
> >  conf/machine/include/machine-xilinx-default.inc | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/conf/machine/include/machine-xilinx-default.inc
> > b/conf/machine/include/machine-xilinx-default.inc
> > index 24d78bc..7b7a549 100644
> > --- a/conf/machine/include/machine-xilinx-default.inc
> > +++ b/conf/machine/include/machine-xilinx-default.inc
> > @@ -42,3 +42,6 @@ XSERVER ?= " \
> >
> >  XSERVER_EXT ?= ""
> >  XSERVER_EXT_zynqmp ?= "xf86-video-armsoc"
> > +
> > +# Support multilib on zynqmp
> > +DEFAULTTUNE_virtclass-multilib-lib32_zynqmp = "armv7vehf-neon-vfpv4"
>
Hi Nathan,

> I think this would be better set in tune-zynqmp.inc (alongside the
> DEFAULTTUNE) as a ?=. That way it is not forced with an override and can be easily
> modified since MULTILIB tunes are really distro level config.
Ok agreed.
>
> Also since the A53 does T32 instructions you should allow thumb with the
> armv7vethf-... variant.

I think we ran into issues during testing, however the armv7vethf is not tested. We can hold off till I can spin another build to test the armv7vethf variant.

Thanks
Manju

>
> Regards,
> Nathan


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.